Skip to content

[baseline][ogre] Disable find_package(QT)#27979

Merged
JavierMatosD merged 3 commits intomicrosoft:masterfrom
dg0yt:ogre-fix
Nov 28, 2022
Merged

[baseline][ogre] Disable find_package(QT)#27979
JavierMatosD merged 3 commits intomicrosoft:masterfrom
dg0yt:ogre-fix

Conversation

@dg0yt
Copy link
Copy Markdown
Contributor

@dg0yt dg0yt commented Nov 23, 2022

  • What does your PR fix?

    Tries to fix ogre build errors when it has Qt6_FOUND despite CMAKE_DISABLE_FIND_PACKAGE(Qt6).

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    unchanged

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    yes

github-actions[bot]
github-actions bot previously approved these changes Nov 23, 2022
View reviewed changes
@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Nov 23, 2022

I consider this change successful: On arm64-windows, the installation order qtbase -> ogre succeeded.
I still need to fix warnings about unused variables. (To be pushed when CI finished.)

@dg0yt dg0yt marked this pull request as ready for review November 23, 2022 20:59
@Cheney-W Cheney-W self-assigned this Nov 24, 2022
@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Nov 24, 2022
@Neumann-A Neumann-A mentioned this pull request Nov 26, 2022
Merged
@JavierMatosD
Copy link
Copy Markdown
Contributor

JavierMatosD commented Nov 28, 2022

Thank you!

@JavierMatosD JavierMatosD merged commit a5fd603 into microsoft:master Nov 28, 2022
@dg0yt dg0yt deleted the ogre-fix branch November 28, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@Cheney-W Cheney-W

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dg0yt @JavierMatosD @Cheney-W