[mailio] correct hint by david-antiteum · Pull Request #23799 · microsoft/vcpkg

david-antiteum · 2022-03-27T13:44:49Z

What does your PR fix?
Fixes [mailio] hint message after installing mailio is incorrect #23798

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/mailio/portfile.cmake

dg0yt · 2022-03-27T15:21:47Z

Could the mailio cmake config be found at all, before this change?

ports/mailio/portfile.cmake

LilyWangLL · 2022-03-28T03:09:14Z

Thanks for your PR, string(COMPARE EQUAL "${VCPKG_LIBRARY_LINKAGE}" "dynamic" BUILD_SHARED) should be removed, I can found where BUILD_SHARED is used.
And PREFER_NINJA should be removed too, vcpkg_cmake_configure doesn't need it.

dg0yt · 2022-03-28T04:04:15Z

ports/mailio/portfile.cmake

 )
 vcpkg_cmake_install()

+vcpkg_fixup_cmake_targets(


This legacy function has been replaced by vcpkg_cmake_config_fixup (from port vcpkg-cmake-config).

It also need add dependency vcpkg-cmake-config in vcpkg.json.

david-antiteum · 2022-03-28T07:07:19Z

@LilyWangLL I just saw this MR #23772 that contain some of these fixes. Maybe you can accept first that MR and then update this one if something is missing.

LilyWangLL · 2022-03-28T08:13:41Z

I think PR #23772 can closed and its fix can merged to this PR, it just add vcpkg_cmake_config_fixup. So could you address the review suggestions? Thanks.

david-antiteum · 2022-03-28T16:37:37Z

Done.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 9ff4659a075d5f4f30aaca9f7c4e7f059ecc1d6d -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/m-/mailio.json b/versions/m-/mailio.json
index dab3280..1fdf4c1 100644
--- a/versions/m-/mailio.json
+++ b/versions/m-/mailio.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "61b298737570de13efc96c3427220b8146140526",
+      "git-tree": "72c0f040b1fbad74b2e6ff069d1dcf996233ef16",
       "version": "0.21.0",
       "port-version": 1
     },

LilyWangLL · 2022-03-29T01:27:19Z

Hi @david-antiteum, can you please resolve the conflicts against master?

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for mailio but no changes to version or port version.
-- Version: 0.21.0#1
-- Old SHA: 80186942edc09cad3c911ebbc6dd77d30af68502
-- New SHA: f0fde0f6599aacd2b890c94326f504bf2af8f642
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 773516ecf6014d89cc69b11bb54605ad4be56694 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/m-/mailio.json b/versions/m-/mailio.json
index 1fdf4c1..571caa9 100644
--- a/versions/m-/mailio.json
+++ b/versions/m-/mailio.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "72c0f040b1fbad74b2e6ff069d1dcf996233ef16",
+      "git-tree": "80186942edc09cad3c911ebbc6dd77d30af68502",
       "version": "0.21.0",
       "port-version": 1
     },

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for mailio but no changes to version or port version.
-- Version: 0.21.0#1
-- Old SHA: 80186942edc09cad3c911ebbc6dd77d30af68502
-- New SHA: f0fde0f6599aacd2b890c94326f504bf2af8f642
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 773516ecf6014d89cc69b11bb54605ad4be56694 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/m-/mailio.json b/versions/m-/mailio.json
index e96c42b..571caa9 100644
--- a/versions/m-/mailio.json
+++ b/versions/m-/mailio.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "f0fde0f6599aacd2b890c94326f504bf2af8f642",
+      "git-tree": "80186942edc09cad3c911ebbc6dd77d30af68502",
       "version": "0.21.0",
       "port-version": 1
     },

LilyWangLL · 2022-03-29T08:41:55Z

@david-antiteum Please update port-version in vcpkg.json. Your version change was overwritten by #23772.

required after merging

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 773516ecf6014d89cc69b11bb54605ad4be56694 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/m-/mailio.json b/versions/m-/mailio.json
index fe4eba4..7cf1089 100644
--- a/versions/m-/mailio.json
+++ b/versions/m-/mailio.json
@@ -6,7 +6,7 @@
       "port-version": 2
     },
     {
-      "git-tree": "f0fde0f6599aacd2b890c94326f504bf2af8f642",
+      "git-tree": "80186942edc09cad3c911ebbc6dd77d30af68502",
       "version": "0.21.0",
       "port-version": 1
     },

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 773516ecf6014d89cc69b11bb54605ad4be56694 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/m-/mailio.json b/versions/m-/mailio.json
index 156df34..5051932 100644
--- a/versions/m-/mailio.json
+++ b/versions/m-/mailio.json
@@ -6,7 +6,7 @@
       "port-version": 2
     },
     {
-      "git-tree": "f0fde0f6599aacd2b890c94326f504bf2af8f642",
+      "git-tree": "80186942edc09cad3c911ebbc6dd77d30af68502",
       "version": "0.21.0",
       "port-version": 1
     },

strega-nil-ms · 2022-04-05T18:17:20Z

Thanks!

microsoft/vcpkg#23799

david-antiteum added 2 commits March 27, 2022 15:42

Solves microsoft#23798

66753dd

Updated baseline

a10d6a6

github-actions bot approved these changes Mar 27, 2022

View reviewed changes

JonLiu1993 assigned LilyWangLL Mar 28, 2022

LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label Mar 28, 2022

LilyWangLL suggested changes Mar 28, 2022

View reviewed changes

ports/mailio/portfile.cmake Show resolved Hide resolved

dg0yt reviewed Mar 28, 2022

View reviewed changes

LilyWangLL added the requires:author-response label Mar 28, 2022

Replace deprecated functions

c4257ee

github-actions bot requested changes Mar 28, 2022

View reviewed changes

Updated baseline

6ef32db

github-actions bot approved these changes Mar 28, 2022

View reviewed changes

david-antiteum requested a review from LilyWangLL March 28, 2022 16:44

Merge branch 'master' into master

e314f34

github-actions bot requested changes Mar 29, 2022

View reviewed changes

Updated hash

78d3928

github-actions bot requested changes Mar 29, 2022

View reviewed changes

david-antiteum added 2 commits March 31, 2022 16:57

new port version

6ef2fb6

required after merging

add version

8909824

github-actions bot requested changes Mar 31, 2022

View reviewed changes

david-antiteum added 2 commits March 31, 2022 17:39

remove duplicate line

13f05bd

updated hash

31ea51c

github-actions bot requested changes Mar 31, 2022

View reviewed changes

LilyWangLL removed the requires:author-response label Apr 1, 2022

LilyWangLL approved these changes Apr 1, 2022

View reviewed changes

LilyWangLL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 1, 2022

david-antiteum mentioned this pull request Apr 5, 2022

Upload your library to vcpkg? karastojko/mailio#39

Closed

strega-nil-ms merged commit bfda043 into microsoft:master Apr 5, 2022

ssauermann added a commit to Seclous/vcpkg-registry that referenced this pull request Jun 10, 2022

Updated Mailio portfile according to official repo

01d457d

microsoft/vcpkg#23799

Conversation

david-antiteum commented Mar 27, 2022

What does your PR fix?

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

dg0yt commented Mar 27, 2022

Uh oh!

Uh oh!

LilyWangLL commented Mar 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dg0yt Mar 28, 2022

Choose a reason for hiding this comment

Uh oh!

LilyWangLL Mar 28, 2022

Choose a reason for hiding this comment

Uh oh!

david-antiteum commented Mar 28, 2022

Uh oh!

LilyWangLL commented Mar 28, 2022

Uh oh!

david-antiteum commented Mar 28, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

LilyWangLL commented Mar 29, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

LilyWangLL commented Mar 29, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

strega-nil-ms commented Apr 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

LilyWangLL commented Mar 28, 2022 •

edited

Loading