[kf5bookmarks] new port#19780
Merged
BillyONeal merged 20 commits intomicrosoft:masterfrom Sep 28, 2021
Merged
Conversation
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 21935b744dc411e0fb1926618fdfb18c67d4b188 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index 11c16cd..2868530 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2892,6 +2892,10 @@
"baseline": "5.84.0",
"port-version": 1
},
+ "kf5bookmarks": {
+ "baseline": "5.84.0",
+ "port-version": 0
+ },
"kf5codecs": {
"baseline": "5.84.0",
"port-version": 1There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 21935b744dc411e0fb1926618fdfb18c67d4b188 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index dd7b832..6ed8d32 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2892,6 +2892,10 @@
"baseline": "5.84.0",
"port-version": 1
},
+ "kf5bookmarks": {
+ "baseline": "5.84.0",
+ "port-version": 0
+ },
"kf5codecs": {
"baseline": "5.84.0",
"port-version": 1There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 21935b744dc411e0fb1926618fdfb18c67d4b188 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index 98c520d..6897fb8 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2892,6 +2892,10 @@
"baseline": "5.84.0",
"port-version": 1
},
+ "kf5bookmarks": {
+ "baseline": "5.84.0",
+ "port-version": 0
+ },
"kf5codecs": {
"baseline": "5.84.0",
"port-version": 1There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout de623488c7d9ab90328ec447f241dfff172b1c45 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index 667255b..c733749 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2892,6 +2892,10 @@
"baseline": "5.84.0",
"port-version": 1
},
+ "kf5bookmarks": {
+ "baseline": "5.84.0",
+ "port-version": 0
+ },
"kf5codecs": {
"baseline": "5.84.0",
"port-version": 1ca26aa9 to
ea9f7a7
Compare
NancyLi1013
approved these changes
Sep 24, 2021
ea9f7a7 to
c90fe9b
Compare
Contributor
|
LGTM now. thanks for adding this port. @wrobelda |
Member
|
Thanks for the new port! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Adds new kf5bookmarks port.
Depends on:
[kf5textwidgets] new port #19766. It was merged to this PR for testing purposes, but please review separately. I will rebase once it gets merged upstream.
[kf5coreaddons] fix Windows static builds & CMake Config #19439. It was merged to this PR for testing purposes, but please review separately. I will rebase once it gets merged upstream.
[kf5xmlgui] New port #19756. It was merged to this PR for testing purposes, but please review separately. I will rebase once it gets merged upstream.
Which triplets are supported/not supported? Have you updated the CI baseline?
All official, plus
arm64-osxDoes your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes