Merged
Conversation
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for kf5iconthemes but no changes to version or port version.
-- Version: 5.84.0
-- Old SHA: 5fd63e3d0747a6c3ba2e2f277acbd2e4129b7762
-- New SHA: a34b5beea612f36368ba352aab740da326efb961
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout dd3d6df5001d49f954bc39b73a4c49ae3c9e8d15 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index cb0149d..ee52d95 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2972,6 +2972,10 @@
"baseline": "5.84.0",
"port-version": 2
},
+ "kf5xmlgui": {
+ "baseline": "5.84.0",
+ "port-version": 0
+ },
"kfr": {
"baseline": "2020-06-15",
"port-version": 0There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout dd3d6df5001d49f954bc39b73a4c49ae3c9e8d15 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index 42cc7c6..742291b 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2972,6 +2972,10 @@
"baseline": "5.84.0",
"port-version": 2
},
+ "kf5xmlgui": {
+ "baseline": "5.84.0",
+ "port-version": 0
+ },
"kfr": {
"baseline": "2020-06-15",
"port-version": 0
This was referenced Aug 28, 2021
Merged
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for kf5xmlgui but no changes to version or port version.
-- Version: 5.84.0
-- Old SHA: 13c451b29d5acffea7c89eb22704e123c211413f
-- New SHA: 6d5edf1912e6ce9800d344af51eb32d7f537c245
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
NancyLi1013
approved these changes
Sep 23, 2021
Contributor
Author
|
@NancyLi1013 since you accepted it I accidentally pushed a fix meant for #20210, removed it and force-pushed. |
Member
|
Thanks for the new port! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Adds new kf5xmlgui port.
Which triplets are supported/not supported? Have you updated the CI baseline?
All official, plus
arm64-osxDoes your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes