Skip to content

[kf5textwidgets] new port#19766

Merged
BillyONeal merged 26 commits intomicrosoft:masterfrom
wrobelda:kf5textwidgets
Sep 14, 2021
Merged

[kf5textwidgets] new port#19766
BillyONeal merged 26 commits intomicrosoft:masterfrom
wrobelda:kf5textwidgets

Conversation

@wrobelda
Copy link
Copy Markdown
Contributor

@wrobelda wrobelda commented Aug 27, 2021 •
edited by JackBoosY
Loading

Describe the pull request

  • What does your PR fix?

    Adds new kf5textwidgets port.
    Depends on:

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    All official.

  • Does your PR follow the maintainer guide?

    Yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes.

@JonLiu1993 JonLiu1993 self-assigned this Aug 27, 2021
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 27, 2021
@wrobelda
Copy link
Copy Markdown
Contributor Author

wrobelda commented Aug 27, 2021

@JonLiu1993 this is now ready for a review, but please notice the dependency I mentioned in my first comment.

@wrobelda wrobelda marked this pull request as ready for review August 27, 2021 14:20
This was referenced Aug 28, 2021
Merged
Merged
@JonLiu1993 JonLiu1993 added the depends:different-pr This PR or Issue depends on a PR which has been filed label Aug 30, 2021
JonLiu1993
JonLiu1993 reviewed Aug 30, 2021
View reviewed changes
JonLiu1993
JonLiu1993 reviewed Aug 30, 2021
View reviewed changes
@wrobelda wrobelda force-pushed the kf5textwidgets branch 2 times, most recently from d78c918 to 1b7984f Compare August 30, 2021 19:02
@wrobelda
[kf5textwidgets] only remove what's needed
fed11cf
@wrobelda
[kf5textwidgets] wrap paths in quotes
c4e6011
@wrobelda
[kf5textwidgets] default data location is OK
5c40db8
@wrobelda
[kf5textwidgets] update versions
9ab0d17
@wrobelda
[kf5textwidgets] DISABLE_PARALLEL_CONFIGURE
a4faf89
@wrobelda
[kf5textwidgets] update versions
98f88b3
@wrobelda
[kf5textwidgets] fix Windows static builds
86942c1
@wrobelda
[kf5textwidgets] update versions
eeff9e0
@wrobelda
[kf5textwidgets] remove /bin when building static
3db7c45
@wrobelda
[kf5textwidgets] update versions
60fdc13
@wrobelda
[kf5textwidgets] add PACKAGE_NAME to vcpkg_cmake_config_fixup
a95574e
@wrobelda
[kf5textwidgets] update versions
04a9997
@wrobelda
[kf5textwidgets] libiconv patches only for windows static builds
819fa2f
@wrobelda
[kf5textwidgets] update versions
720a770
@wrobelda
[kf5textwidgets] cleanup, iconv was fixed in kf5i18n
c86e5ae
@wrobelda
[kf5textwidgets] update versions
226d7fd
@wrobelda
Copy link
Copy Markdown
Contributor Author

wrobelda commented Sep 10, 2021 •
edited
Loading

@wrobelda ,This pr also depends on #20090 ?

@JonLiu1993 not really, the #20016 provided all the fixes for kf5i18n. Once #20090 gets merged, I'll update kf5i18n and remove its patch.

#20016 was merged to master already, so I rebased this PR and it's good to go.

@JonLiu1993 JonLiu1993 added requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. labels Sep 13, 2021
@BillyONeal BillyONeal merged commit f446c96 into microsoft:master Sep 14, 2021
@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Sep 14, 2021

Thanks again!

@wrobelda wrobelda mentioned this pull request Sep 15, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

+1 more reviewer

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JonLiu1993 JonLiu1993

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR! info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wrobelda @ras0219-msft @JonLiu1993 @BillyONeal @hellozee