[vcpkg_from_git] Fix error if downloads folder does not exist#18758
Closed
ras0219-msft wants to merge 2 commits intomicrosoft:masterfrom
Closed
[vcpkg_from_git] Fix error if downloads folder does not exist#18758ras0219-msft wants to merge 2 commits intomicrosoft:masterfrom
ras0219-msft wants to merge 2 commits intomicrosoft:masterfrom
Conversation
Member
|
I don't think this is sufficient because there are similar places all over the tool that expect the downloads directory to already exist, in particular bootstrap and friends. Do we know how we got to this 'downloads doesn't exist' condition in the first place? |
Contributor
|
@BillyONeal everywhere else should use |
strega-nil-ms
approved these changes
Jul 6, 2021
Member
bootstrap does not use |
Contributor
|
@BillyONeal |
vicroms
approved these changes
Jul 6, 2021
Contributor
|
Closing for rollup #18838 |
strega-nil-ms
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
Jul 13, 2021
[vcpkg_from_git] Fix error if downloads folder does not exist
BillyONeal
pushed a commit
that referenced
this pull request
Jul 14, 2021
* [rollup:2021-07-06 1/8] PR #18272 (@strega-nil) [scripts-audit] vcpkg_from_* * [rollup:2021-07-06 2/8] PR #18319 (@strega-nil) [scripts-audit] add guidelines for cmake * [rollup 2021-07-06 3/8] PR #18410 (@mheyman) [vcpkg-cmake-config] documentation fix * [rollup:2021-07-06 4/8] PR #18488 (@strega-nil) [scripts-audit] vcpkg_execute_* * [rollup:2021-07-06 5/8] PR #18517 (@strega-nil) [scripts-audit] vcpkg_extract_source_archive * [rollup:2021-07-06 6/8] PR #18674 (@NancyLi1013) [vcpkg doc] Update examples * [rollup:2021-07-06 7/8] PR #18695 (@JackBoosY) [vcpkg] Update the minimum version of vcpkg * [rollup:2021-07-06 8/8] PR #18758 (@ras0219-msft) [vcpkg_from_git] Fix error if downloads folder does not exist * build docs! * fix bond:*-windows * fix nmap Co-authored-by: nicole mazzuca <mazzucan@outlook.com> Co-authored-by: Michael Heyman <Michael.Heyman@jhuapl.edu> Co-authored-by: NancyLi1013 <lirui09@beyondsoft.com> Co-authored-by: JackBoosY <yuzaiyang@beyondsoft.com> Co-authored-by: Robert Schumacher <ras0219@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #18705:
This PR actually fixes the root cause.