Skip to content

[vcpkg doc] Update examples#18674

Closed
NancyLi1013 wants to merge 2 commits intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/update-doc
Closed

[vcpkg doc] Update examples#18674
NancyLi1013 wants to merge 2 commits intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/update-doc

Conversation

@NancyLi1013
Copy link
Copy Markdown
Contributor

Describe the pull request

The original examples in vcpkg_install_msbuild and vcpkg_clean_msbuild are outdated. Since these ports don't use msbuild now.

So add other ports that use msbuild as the examples in these docs.

@NancyLi1013 NancyLi1013 added category:documentation To resolve the issue, documentation will need to be updated info:internal labels Jun 28, 2021
@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 6, 2021
@strega-nil-ms
Copy link
Copy Markdown
Contributor

Closed for rollup PR #18838

strega-nil-ms pushed a commit to strega-nil/vcpkg that referenced this pull request Jul 13, 2021
BillyONeal pushed a commit that referenced this pull request Jul 14, 2021
* [rollup:2021-07-06 1/8] PR #18272 (@strega-nil)

[scripts-audit] vcpkg_from_*

* [rollup:2021-07-06 2/8] PR #18319 (@strega-nil)

[scripts-audit] add guidelines for cmake

* [rollup 2021-07-06 3/8] PR #18410 (@mheyman)

[vcpkg-cmake-config] documentation fix

* [rollup:2021-07-06 4/8] PR #18488 (@strega-nil)

[scripts-audit] vcpkg_execute_*

* [rollup:2021-07-06 5/8] PR #18517 (@strega-nil)

[scripts-audit] vcpkg_extract_source_archive

* [rollup:2021-07-06 6/8] PR #18674 (@NancyLi1013)

[vcpkg doc] Update examples

* [rollup:2021-07-06 7/8] PR #18695 (@JackBoosY)

[vcpkg] Update the minimum version of vcpkg

* [rollup:2021-07-06 8/8] PR #18758 (@ras0219-msft)

[vcpkg_from_git] Fix error if downloads folder does not exist

* build docs!

* fix bond:*-windows

* fix nmap

Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
Co-authored-by: Michael Heyman <Michael.Heyman@jhuapl.edu>
Co-authored-by: NancyLi1013 <lirui09@beyondsoft.com>
Co-authored-by: JackBoosY <yuzaiyang@beyondsoft.com>
Co-authored-by: Robert Schumacher <ras0219@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:documentation To resolve the issue, documentation will need to be updated info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation for vcpkg_install_msbuild list two example ports that use it, but those ports no longer do

3 participants