[scripts-audit] z_vcpkg_function_arguments#16193
Merged
strega-nil merged 2 commits intomicrosoft:masterfrom Feb 13, 2021
Merged
[scripts-audit] z_vcpkg_function_arguments#16193strega-nil merged 2 commits intomicrosoft:masterfrom
strega-nil merged 2 commits intomicrosoft:masterfrom
Conversation
fix bug when ARGC = 0
ras0219-msft
approved these changes
Feb 13, 2021
Jimmy-Hu
added a commit
to Jimmy-Hu/vcpkg
that referenced
this pull request
Feb 13, 2021
[scripts-audit] z_vcpkg_function_arguments (microsoft#16193)
strega-nil
added a commit
that referenced
this pull request
Feb 19, 2021
* [vcpkg.cmake] modify to get in line with the audit See PR #16055 This also (attempts to) allow vcpkg.cmake to run with cmake 3.0; we had a VERSION_GREATER_EQUAL check, but that if keyword was added in cmake 3.7. * s/target_name/package_name in find_package * depend on z_vcpkg_function_arguments instead of a custom macro also, as a drive-by, switch to foreach(X IN LISTS ...) * split the utility macros/functions out additionally, move the options and settings to the top of the file * move more options and settings to the top * fix name of file * fix ras code comments * remove z_vcpkg_utilities due to export * add cmake_policy(PUSH|POP) * add VCPKG_INSTALLED_DIR input variable * add .cmakestamp to vcpkg_installed * fix osx ifs to use quotes also, remove spaces between if and (, to keep style consistent (mostly for ease of grepping...) * fix bug fixed by #16193 * move z_vcpkg_add_fatal_error up * fix RANGE for reals
51 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix bug when ARGC = 0 or ARGC > FIRST_ARG