[scripts-audit] vcpkg.cmake#16061
Merged
strega-nil merged 11 commits intomicrosoft:masterfrom Feb 19, 2021
Merged
Conversation
BillyONeal
reviewed
Feb 5, 2021
20f4464 to
0a6efac
Compare
Neumann-A
reviewed
Feb 5, 2021
Neumann-A
reviewed
Feb 5, 2021
Neumann-A
reviewed
Feb 5, 2021
Contributor
|
I would really like to see some cleanup first instead of more things added to |
0a6efac to
05cd057
Compare
ras0219-msft
reviewed
Feb 8, 2021
Contributor
ras0219-msft
left a comment
There was a problem hiding this comment.
The pieces I've reviewed LGTM so far.
Still to review:
- New macro/functions
find_package()override
Contributor
Author
|
|
5a4d951 to
af09646
Compare
See PR microsoft#16055 This also (attempts to) allow vcpkg.cmake to run with cmake 3.0; we had a VERSION_GREATER_EQUAL check, but that if keyword was added in cmake 3.7.
instead of a custom macro also, as a drive-by, switch to foreach(X IN LISTS ...)
additionally, move the options and settings to the top of the file
635c356 to
e83e7bb
Compare
* remove z_vcpkg_utilities due to export * add cmake_policy(PUSH|POP) * add VCPKG_INSTALLED_DIR input variable * add .cmakestamp to vcpkg_installed
also, remove spaces between if and (, to keep style consistent (mostly for ease of grepping...)
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BillyONeal
approved these changes
Feb 18, 2021
Jimmy-Hu
added a commit
to Jimmy-Hu/vcpkg
that referenced
this pull request
Feb 19, 2021
[scripts-audit] vcpkg.cmake (microsoft#16061)
Contributor
|
@strega-nil Did you try the vcpkg.cmake script after the re-work (audit?) on a downstream project? |
51 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See PR #16055
This also (attempts to) allow vcpkg.cmake to run with cmake 3.1; we had a
VERSION_GREATER_EQUALcheck, but that if keyword was added in cmake 3.7.