Skip to content

Add cppwinrt#154

Merged
ras0219-msft merged 2 commits intomicrosoft:masterfrom
sgreenlay:master
Oct 13, 2016
Merged

Add cppwinrt#154
ras0219-msft merged 2 commits intomicrosoft:masterfrom
sgreenlay:master

Conversation

@sgreenlay
Copy link
Copy Markdown
Contributor

@sgreenlay sgreenlay commented Oct 13, 2016 •
edited
Loading

C++/WinRT is a header-only C++ language projection for the Windows Runtime published by Microsoft.

Official GitHub: https://github.com/Microsoft/cppwinrt

@msftclas
Copy link
Copy Markdown

msftclas commented Oct 13, 2016

Hi @sgreenlay, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link
Copy Markdown

msftclas commented Oct 13, 2016

@sgreenlay, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@sgreenlay sgreenlay mentioned this pull request Oct 13, 2016
Closed
BrentRe
BrentRe suggested changes Oct 13, 2016
View reviewed changes
Copy link
Copy Markdown

@BrentRe BrentRe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HEADER_PATH variable is set to the incorrect folder. It should point to 10.0.14393.0 and not to the 'winrt' sub-folder. See the cppwinrt Doc on Header File Design for the reason.

@sgreenlay
Copy link
Copy Markdown
Contributor Author

sgreenlay commented Oct 13, 2016

Thanks! HEADER_PATH was an local variable, but I've removed it to avoid confusion. The port file still copies the headers from 10.0.14393.0/winrt to include/winrt.

@ras0219-msft ras0219-msft merged commit 0c260fb into microsoft:master Oct 13, 2016
@ras0219-msft
Copy link
Copy Markdown
Contributor

ras0219-msft commented Oct 13, 2016

Thanks for the fast PR here 👍

@sdcb sdcb mentioned this pull request Oct 14, 2016
Closed
ras0219-msft pushed a commit that referenced this pull request Apr 2, 2021
@DigitalInBlue @JonLiu1993
[celero] Updated to Celero v2.8.0 (#16802)
030cfaa 
* [celero] Updated to Celero v2.8.0

* [celero] Improving static linking support in VCPKG.

Celero issue #154 is tracking a fix.
DigitalInBlue/Celero#154

* [celero] Updated to v2.8.1

* [celero] Updated version for VCPKG.

* [celero] Updates to better support VCPKG.

* [celero] Updated versions.

* Update celero.json

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
prateek9623 added a commit to prateek9623/vcpkg that referenced this pull request Apr 7, 2021
@prateek9623 @JonLiu1993
[celero] Updated to Celero v2.8.0 (microsoft#16802)
dfa9557 
* [celero] Updated to Celero v2.8.0

* [celero] Improving static linking support in VCPKG.

Celero issue microsoft#154 is tracking a fix.
DigitalInBlue/Celero#154

* [celero] Updated to v2.8.1

* [celero] Updated version for VCPKG.

* [celero] Updates to better support VCPKG.

* [celero] Updated versions.

* Update celero.json

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
vicroms pushed a commit that referenced this pull request Apr 9, 2021
@prateek9623 @JonLiu1993
[minizip-ng] add new port (#17101)
06fd7cc 
* [minizip-ng] add new port

* [celero] Updated to Celero v2.8.0 (#16802)

* [celero] Updated to Celero v2.8.0

* [celero] Improving static linking support in VCPKG.

Celero issue #154 is tracking a fix.
DigitalInBlue/Celero#154

* [celero] Updated to v2.8.1

* [celero] Updated version for VCPKG.

* [celero] Updates to better support VCPKG.

* [celero] Updated versions.

* Update celero.json

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
dempo93 pushed a commit to dempo93/vcpkg that referenced this pull request Aug 23, 2022
@facontidavide
Merge pull request microsoft#154 from janelia-ros/doc-devel
3bb38d8 
Modify documentation images.
JoergAtGithub pushed a commit to JoergAtGithub/vcpkg that referenced this pull request Apr 9, 2025
@daschuer
Merge pull request microsoft#154 from acolombier/chore/update-ci
e6ce218 
Update upload and action and CI nit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@BrentRe BrentRe BrentRe requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sgreenlay @msftclas @ras0219-msft @BrentRe