[minizip-ng] add new port by prateek9623 · Pull Request #17101 · microsoft/vcpkg

prateek9623 · 2021-04-05T15:27:40Z

Describe the pull request

What does your PR fix? Fixes [New Port Request] minizip, maintained fork #12917
Which triplets are supported/not supported? Have you updated the CI baseline?
Except for UWP, all officials should be supported.
Does your PR follow the maintainer guide?
yes

ghost · 2021-04-05T15:27:53Z

All CLA requirements met.

autoantwort · 2021-04-05T15:32:12Z

Run ./vcpkg format-manifest ports/minizip-ng/vcpkg.json to make the pipeline happy :)

autoantwort · 2021-04-05T15:44:41Z

I think you don't support uwp, so add "supports": "!uwp" to your vcpkg.json file and run the format thing again :)

autoantwort · 2021-04-05T15:54:00Z

Now a final ./vcpkg x-add-version --overwrite-version minizip-ng and the PR should be ready :)

autoantwort · 2021-04-05T15:58:17Z

I have looked at the linked Issue and found https://github.com/oswjk/vcpkg-minizip-fork, is there a reason why you have not reused these files?

prateek9623 · 2021-04-05T16:02:57Z

I have looked at the linked Issue and found https://github.com/oswjk/vcpkg-minizip-fork, is there a reason why you have not reused these files?

those files are pretty old, we don't require those patches now.

autoantwort · 2021-04-05T16:05:53Z

Ok, I asked because https://github.com/oswjk/vcpkg-minizip-fork/blob/master/CONTROL supported a lot more features than this PR

prateek9623 · 2021-04-05T16:08:05Z

Ok, I asked because https://github.com/oswjk/vcpkg-minizip-fork/blob/master/CONTROL supported a lot more features than this PR

Ya, I know, but I don't that should we support it or not. I have linked this PR to the minizip-ng repo owner zlib-ng/minizip-ng#540

nmoinvaz · 2021-04-05T21:54:50Z

ports/minizip-ng/vcpkg.json

OpenSSL is not needed on Apple as it can use CommonCrypto.

nmoinvaz · 2021-04-05T21:55:08Z

ports/minizip-ng/vcpkg.json

Does it not work on UWP? I have not tested it personally.

ya CI was failing on it

No, the error was:

Microsoft (R) Build Engine version 16.8.2+25e4d540b for .NET Framework Copyright (C) Microsoft Corporation. All rights reserved. Build started 4/5/2021 3:39:57 PM. 1>Project "D:\buildtrees\minizip-ng\x64-uwp-dbg\install.vcxproj" on node 1 (default targets). 1>Project "D:\buildtrees\minizip-ng\x64-uwp-dbg\install.vcxproj" (1) is building "D:\buildtrees\minizip-ng\x64-uwp-dbg\ZERO_CHECK.vcxproj" (2) on node 1 (default targets). 2>PrepareForBuild: Creating directory "x64\Debug\ZERO_CHECK\". Creating directory "x64\Debug\ZERO_CHECK\ZERO_CHECK.tlog\". Creating directory "Generated Files\". InitializeBuildStatus: Creating "x64\Debug\ZERO_CHECK\ZERO_CHECK.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified. CustomBuild: Checking Build System FinalizeBuildStatus: Deleting file "x64\Debug\ZERO_CHECK\ZERO_CHECK.tlog\unsuccessfulbuild". Touching "x64\Debug\ZERO_CHECK\ZERO_CHECK.tlog\ZERO_CHECK.lastbuildstate". 2>Done Building Project "D:\buildtrees\minizip-ng\x64-uwp-dbg\ZERO_CHECK.vcxproj" (default targets). 1>Project "D:\buildtrees\minizip-ng\x64-uwp-dbg\install.vcxproj" (1) is building "D:\buildtrees\minizip-ng\x64-uwp-dbg\ALL_BUILD.vcxproj" (3) on node 2 (default targets). 3>Project "D:\buildtrees\minizip-ng\x64-uwp-dbg\ALL_BUILD.vcxproj" (3) is building "D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj" (4) on node 2 (default targets). 4>PrepareForBuild: Creating directory "minizip-ng.dir\Debug\". Creating directory "D:\buildtrees\minizip-ng\x64-uwp-dbg\Debug\". Creating directory "minizip-ng.dir\Debug\minizip-ng.tlog\". GetInstalledSDKLocations: Searching for SDKs targeting "UAP, 10.0.19041.0". Searching for SDKs targeting "Windows, 8.1". ResolveSDKReferences: Reading SDK manifest file "C:\Program Files (x86)\Microsoft SDKs\Windows Kits\10\ExtensionSDKs\Microsoft.VCLibs\14.0\SDKManifest.xml". Targeted configuration and architecture "Debug|x64" Could not find "FrameworkIdentity" attribute "FrameworkIdentity-Debug-x64" in the SDK manifest. Found "FrameworkIdentity" attribute "Name = Microsoft.VCLibs.140.00.Debug, MinVersion = 14.0.27810.0, Publisher = 'CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US'" in the SDK manifest. Found "APPX" location attribute "AppX-Debug-x86=.\AppX\Debug\x86\Microsoft.VCLibs.x86.Debug.14.00.appx" in the SDK manifest. Found "APPX" location attribute "AppX-Debug-x64=.\AppX\Debug\x64\Microsoft.VCLibs.x64.Debug.14.00.appx" in the SDK manifest. Found "APPX" location attribute "AppX-Debug-ARM=.\AppX\Debug\ARM\Microsoft.VCLibs.ARM.Debug.14.00.appx" in the SDK manifest. Found "APPX" location attribute "AppX-Debug-ARM64=.\AppX\Debug\ARM64\Microsoft.VCLibs.ARM64.Debug.14.00.appx" in the SDK manifest. ExpandSDKReferences: Enumerating SDK Reference "Microsoft.VCLibs, Version=14.0" from "C:\Program Files (x86)\Microsoft SDKs\Windows Kits\10\ExtensionSDKs\Microsoft.VCLibs\14.0\". InitializeBuildStatus: Creating "minizip-ng.dir\Debug\minizip-ng.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified. CustomBuild: Building Custom Rule D:/buildtrees/minizip-ng/src/3.0.1-4535e59d51.clean/CMakeLists.txt ClCompile: C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.28.29333\bin\HostX64\x64\CL.exe /c /I"D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean" /I"D:\installed\x64-uwp\include" /I"D:\buildtrees\minizip-ng\x64-uwp-dbg\\" /I"Generated Files\\" /I"minizip-ng.dir\Debug\\" /Zi /nologo /W3 /WX- /diagnostics:column /sdl /MP /Od /Ob0 /Oi /Oy- /D WIN32 /D _WINDOWS /D _DEBUG /D HAVE_STDINT_H /D HAVE_INTTYPES_H /D NO_FSEEKO /D HAVE_ZLIB /D HAVE_BZIP2 /D HAVE_LZMA /D LZMA_API_STATIC /D HAVE_ZSTD /D _CRT_SECURE_NO_DEPRECATE /D MZ_WINRT_API /D MZ_ZIP_SIGNING /D HAVE_PKCRYPT /D HAVE_WZAES /D "CMAKE_INTDIR=\"Debug\"" /D MZ_EXPORTS /D _WINDLL /D _UNICODE /D UNICODE /D WINAPI_FAMILY=WINAPI_FAMILY_APP /D __WRL_NO_DEFAULT_LIB__ /Gm- /RTC1 /MDd /GS /Gy /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"minizip-ng.dir\Debug\\" /Fd"minizip-ng.dir\Debug\vc142.pdb" /Gd /TC /FU"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.28.29333\lib\x86\store\references\platform.winmd" /analyze- /errorReport:queue /utf-8 "D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt.c" "D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_os.c" "D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_strm.c" "D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_strm_buf.c" "D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_strm_mem.c" "D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_strm_split.c" "D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_zip.c" "D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_zip_rw.c" "D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_strm_zlib.c" "D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_strm_bzip.c" "D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_strm_lzma.c" "D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_strm_zstd.c" "D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_os_win32.c" "D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_strm_os_win32.c" "D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c" "D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_strm_pkcrypt.c" "D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_strm_wzaes.c" "D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_compat.c" mz_crypt.c mz_os.c mz_strm.c mz_strm_buf.c mz_strm_mem.c mz_strm_split.c mz_zip.c mz_zip_rw.c mz_strm_zlib.c mz_strm_bzip.c mz_strm_lzma.c mz_strm_zstd.c mz_os_win32.c mz_strm_os_win32.c mz_crypt_win32.c mz_strm_pkcrypt.c mz_strm_wzaes.c mz_compat.c 4>D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(25,33): warning C4013: 'CryptAcquireContext' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] 4>D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(27,32): warning C4013: 'CryptGenRandom' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] 4>D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(50,25): warning C4013: 'CryptDestroyHash' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] 4>D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(80,33): warning C4013: 'CryptCreateHash' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] 4>D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(96,27): warning C4013: 'CryptHashData' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] 4>D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(111,31): warning C4013: 'CryptGetHashParam' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] 4>D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(169,24): warning C4013: 'CryptDestroyKey' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] 4>D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(188,26): warning C4013: 'CryptEncrypt' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] 4>D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(203,26): warning C4013: 'CryptDecrypt' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] 4>D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(255,36): warning C4013: 'CryptImportKey' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] 4>D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(265,34): warning C4013: 'CryptSetKeyParam' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] 4>D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(402,39): warning C4013: 'CryptSetHashParam' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] 4>D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(472,32): warning C4013: 'CryptDuplicateHash' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] 4>D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(599,38): warning C4013: 'CryptSignMessage' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] 4>D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(640,41): warning C4013: 'CryptVerifyMessageSignature' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] Link: C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.28.29333\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:"D:\buildtrees\minizip-ng\x64-uwp-dbg\Debug\libminizip-ng.dll" /INCREMENTAL /NOLOGO "D:\installed\x64-uwp\debug\lib\zlibd.lib" "D:\installed\x64-uwp\debug\lib\bz2d.lib" "D:\installed\x64-uwp\debug\lib\lzmad.lib" "D:\installed\x64-uwp\debug\lib\zstdd.lib" crypt32.lib WindowsApp.lib /MANIFEST /ManifestFile:"minizip-ng.dir\Debug\libminizip-ng.dll.intermediate.manifest" /MANIFESTUAC:NO /DEBUG /PDB:"D:/buildtrees/minizip-ng/x64-uwp-dbg/Debug/libminizip-ng.pdb" /SUBSYSTEM:CONSOLE /OPT:REF /OPT:ICF /TLBID:1 /APPCONTAINER /WINMD:NO /WINMDFILE:"D:\buildtrees\minizip-ng\x64-uwp-dbg\Debug\libminizip-ng.winmd" /DYNAMICBASE /NXCOMPAT /IMPLIB:"D:/buildtrees/minizip-ng/x64-uwp-dbg/Debug/libminizip-ng.lib" /MACHINE:X64 /machine:x64 /nologo /DLL "minizip-ng.dir\Debug\mz_crypt.obj" "minizip-ng.dir\Debug\mz_os.obj" "minizip-ng.dir\Debug\mz_strm.obj" "minizip-ng.dir\Debug\mz_strm_buf.obj" "minizip-ng.dir\Debug\mz_strm_mem.obj" "minizip-ng.dir\Debug\mz_strm_split.obj" "minizip-ng.dir\Debug\mz_zip.obj" "minizip-ng.dir\Debug\mz_zip_rw.obj" "minizip-ng.dir\Debug\mz_strm_zlib.obj" "minizip-ng.dir\Debug\mz_strm_bzip.obj" "minizip-ng.dir\Debug\mz_strm_lzma.obj" "minizip-ng.dir\Debug\mz_strm_zstd.obj" "minizip-ng.dir\Debug\mz_os_win32.obj" "minizip-ng.dir\Debug\mz_strm_os_win32.obj" "minizip-ng.dir\Debug\mz_crypt_win32.obj" "minizip-ng.dir\Debug\mz_strm_pkcrypt.obj" "minizip-ng.dir\Debug\mz_strm_wzaes.obj" "minizip-ng.dir\Debug\mz_compat.obj" 4>LINK : warning LNK4075: ignoring '/INCREMENTAL' due to '/OPT:ICF' specification [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] Creating library D:/buildtrees/minizip-ng/x64-uwp-dbg/Debug/libminizip-ng.lib and object D:/buildtrees/minizip-ng/x64-uwp-dbg/Debug/libminizip-ng.exp 4>mz_crypt_win32.obj : error LNK2019: unresolved external symbol CryptAcquireContext referenced in function mz_crypt_aes_set_key [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] 4>mz_crypt_win32.obj : error LNK2019: unresolved external symbol CryptDuplicateHash referenced in function mz_crypt_hmac_copy [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] 4>D:\buildtrees\minizip-ng\x64-uwp-dbg\Debug\libminizip-ng.dll : fatal error LNK1120: 2 unresolved externals [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] 4>Done Building Project "D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj" (default targets) -- FAILED. 3>Done Building Project "D:\buildtrees\minizip-ng\x64-uwp-dbg\ALL_BUILD.vcxproj" (default targets) -- FAILED. 1>Done Building Project "D:\buildtrees\minizip-ng\x64-uwp-dbg\install.vcxproj" (default targets) -- FAILED. Build FAILED. "D:\buildtrees\minizip-ng\x64-uwp-dbg\install.vcxproj" (default target) (1) -> "D:\buildtrees\minizip-ng\x64-uwp-dbg\ALL_BUILD.vcxproj" (default target) (3) -> "D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj" (default target) (4) -> (ClCompile target) -> D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(25,33): warning C4013: 'CryptAcquireContext' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(27,32): warning C4013: 'CryptGenRandom' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(50,25): warning C4013: 'CryptDestroyHash' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(80,33): warning C4013: 'CryptCreateHash' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(96,27): warning C4013: 'CryptHashData' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(111,31): warning C4013: 'CryptGetHashParam' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(169,24): warning C4013: 'CryptDestroyKey' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(188,26): warning C4013: 'CryptEncrypt' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(203,26): warning C4013: 'CryptDecrypt' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(255,36): warning C4013: 'CryptImportKey' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(265,34): warning C4013: 'CryptSetKeyParam' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(402,39): warning C4013: 'CryptSetHashParam' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(472,32): warning C4013: 'CryptDuplicateHash' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(599,38): warning C4013: 'CryptSignMessage' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] D:\buildtrees\minizip-ng\src\3.0.1-4535e59d51.clean\mz_crypt_win32.c(640,41): warning C4013: 'CryptVerifyMessageSignature' undefined; assuming extern returning int [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] "D:\buildtrees\minizip-ng\x64-uwp-dbg\install.vcxproj" (default target) (1) -> "D:\buildtrees\minizip-ng\x64-uwp-dbg\ALL_BUILD.vcxproj" (default target) (3) -> "D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj" (default target) (4) -> (Link target) -> LINK : warning LNK4075: ignoring '/INCREMENTAL' due to '/OPT:ICF' specification [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] "D:\buildtrees\minizip-ng\x64-uwp-dbg\install.vcxproj" (default target) (1) -> "D:\buildtrees\minizip-ng\x64-uwp-dbg\ALL_BUILD.vcxproj" (default target) (3) -> "D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj" (default target) (4) -> (Link target) -> mz_crypt_win32.obj : error LNK2019: unresolved external symbol CryptAcquireContext referenced in function mz_crypt_aes_set_key [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] mz_crypt_win32.obj : error LNK2019: unresolved external symbol CryptDuplicateHash referenced in function mz_crypt_hmac_copy [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] D:\buildtrees\minizip-ng\x64-uwp-dbg\Debug\libminizip-ng.dll : fatal error LNK1120: 2 unresolved externals [D:\buildtrees\minizip-ng\x64-uwp-dbg\minizip-ng.vcxproj] 16 Warning(s) 3 Error(s) Time Elapsed 00:00:01.79

Seems to be the difference between Crypt and BCrypt, never even heard of BCrypt. That would be something good to add into minizip-ng one day.

crypto missing?

All the Windows crypto functions would need to be prefixed with B.

prateek9623 · 2021-04-05T22:03:49Z

@nmoinvaz this https://github.com/oswjk/vcpkg-minizip-fork/blob/master/CONTROL was a previous attempt to add vcpkg port, as you can see here there are many features in this port. so, what do think, who many features should we support?

nmoinvaz · 2021-04-05T22:08:26Z

I am somewhat of the opinion that it should support most of the features for completeness at least the ones for turning on/off compression libraries. But how far you want to take it I would leave at your discretion.

prateek9623 · 2021-04-05T22:17:39Z

I am somewhat of the opinion that it should support most of the features for completeness at least the ones for turning on/off compression libraries. But how far you want to take it I would leave at your discretion.

am fine with this, for now, maybe will add support for zlib-ng

PhoebeHui

@prateek9623, thanks for the PR!

ports/minizip-ng/vcpkg.json

ports/minizip-ng/portfile.cmake

* [celero] Updated to Celero v2.8.0 * [celero] Improving static linking support in VCPKG. Celero issue microsoft#154 is tracking a fix. DigitalInBlue/Celero#154 * [celero] Updated to v2.8.1 * [celero] Updated version for VCPKG. * [celero] Updates to better support VCPKG. * [celero] Updated versions. * Update celero.json Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

prateek9623 marked this pull request as ready for review April 5, 2021 15:31

prateek9623 mentioned this pull request Apr 5, 2021

adding to vcpkg zlib-ng/minizip-ng#540

Closed

prateek9623 force-pushed the minizip-ng-support branch from 118c9ac to 0bb2387 Compare April 5, 2021 15:35

prateek9623 force-pushed the minizip-ng-support branch from 0bb2387 to bf78015 Compare April 5, 2021 15:47

prateek9623 force-pushed the minizip-ng-support branch from bf78015 to 7dfadfd Compare April 5, 2021 15:55

nmoinvaz reviewed Apr 5, 2021

View reviewed changes

ports/minizip-ng/vcpkg.json Outdated

Copy link
Copy Markdown

nmoinvaz Apr 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenSSL is not needed on Apple as it can use CommonCrypto.

nmoinvaz reviewed Apr 5, 2021

View reviewed changes

prateek9623 force-pushed the minizip-ng-support branch from 7dfadfd to 2688278 Compare April 5, 2021 22:00

prateek9623 force-pushed the minizip-ng-support branch from 2688278 to 7d29780 Compare April 5, 2021 22:07

NancyLi1013 assigned PhoebeHui Apr 6, 2021

PhoebeHui added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Apr 6, 2021

PhoebeHui suggested changes Apr 6, 2021

View reviewed changes

ports/minizip-ng/vcpkg.json Outdated Show resolved Hide resolved

ports/minizip-ng/portfile.cmake Outdated Show resolved Hide resolved

ports/minizip-ng/portfile.cmake Outdated Show resolved Hide resolved

PhoebeHui added the requires:author-response label Apr 6, 2021

prateek9623 force-pushed the minizip-ng-support branch from 7d29780 to 5626a38 Compare April 6, 2021 11:25

prateek9623 requested a review from PhoebeHui April 6, 2021 11:26

prateek9623 force-pushed the minizip-ng-support branch 2 times, most recently from 02ae86c to b356f6a Compare April 6, 2021 11:50

[minizip-ng] add new port

cf0db03

prateek9623 force-pushed the minizip-ng-support branch from b356f6a to cf0db03 Compare April 6, 2021 11:55

PhoebeHui requested a review from strega-nil April 7, 2021 02:18

PhoebeHui removed the requires:author-response label Apr 7, 2021

PhoebeHui suggested changes Apr 7, 2021

View reviewed changes

ports/minizip-ng/portfile.cmake Show resolved Hide resolved

PhoebeHui added the requires:author-response label Apr 7, 2021

prateek9623 force-pushed the minizip-ng-support branch from aff4a05 to dfa9557 Compare April 7, 2021 13:24

PhoebeHui approved these changes Apr 8, 2021

View reviewed changes

PhoebeHui added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Apr 8, 2021

vicroms merged commit 06fd7cc into microsoft:master Apr 9, 2021

prateek9623 deleted the minizip-ng-support branch April 9, 2021 17:07

prateek9623 restored the minizip-ng-support branch April 9, 2021 17:07

prateek9623 deleted the minizip-ng-support branch April 9, 2021 17:07

luncliff mentioned this pull request May 24, 2021

[zlib 1.2.11] update to [zlib-ng 2.0.3] #18062

Closed

luncliff mentioned this pull request Jun 1, 2021

[zlib-ng] create a new port #18223

Merged

Conversation

prateek9623 commented Apr 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Apr 5, 2021 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

autoantwort commented Apr 5, 2021

Uh oh!

autoantwort commented Apr 5, 2021

Uh oh!

autoantwort commented Apr 5, 2021

Uh oh!

autoantwort commented Apr 5, 2021

Uh oh!

prateek9623 commented Apr 5, 2021

Uh oh!

autoantwort commented Apr 5, 2021

Uh oh!

prateek9623 commented Apr 5, 2021

Uh oh!

nmoinvaz Apr 5, 2021

Choose a reason for hiding this comment

Uh oh!

nmoinvaz Apr 5, 2021

Choose a reason for hiding this comment

Uh oh!

prateek9623 Apr 5, 2021

Choose a reason for hiding this comment

Uh oh!

autoantwort Apr 5, 2021

Choose a reason for hiding this comment

Uh oh!

nmoinvaz Apr 5, 2021

Choose a reason for hiding this comment

Uh oh!

prateek9623 Apr 5, 2021

Choose a reason for hiding this comment

Uh oh!

nmoinvaz Apr 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prateek9623 commented Apr 5, 2021

Uh oh!

nmoinvaz commented Apr 5, 2021

Uh oh!

prateek9623 commented Apr 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PhoebeHui left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

prateek9623 commented Apr 5, 2021 •

edited

Loading

ghost commented Apr 5, 2021 •

edited by ghost

Loading

nmoinvaz Apr 7, 2021 •

edited

Loading

prateek9623 commented Apr 5, 2021 •

edited

Loading