Merged
Conversation
|
great to see that oneDNN is making its way here! And thanks for the port @jacobkahn :-) Do you have any particular workloads where you see oneDNN with MKL faster than oneDNN without MKL? |
Contributor
Author
|
@mgouicem — happy to help 👍 - we're about to use the port in flashlight for our new CPU/OpenCL backends I have zero current benchmarks or supporting evidence that linking with MKL is faster besides that it used to be a bit faster with very old versions of MKL-DNN that I last benchmarked on. If it's just as good without, I'll happily gut the dependency (it makes life easier!). Thanks for the pointer there. |
jacobkahn
added a commit
to jacobkahn/flashlight
that referenced
this pull request
Dec 12, 2020
Summary: Fix the Docker image build - Use multiple `RUN` commands with `docker prune` to allow checkingpointing the base image builds to make it easier to debug stuff in the future - Make `MKLROOT` a global env var - Remove the MKL BLAS vendor for oneDNN (apparently faster without MKL) - see microsoft/vcpkg#15068 (comment) - Enable building tests in the CPU CI build since it works now and `gtest_discover_tests` is removed so we don't have runtime `libmlk_rt` issues. We also shouldn't have those issues anymore in general because we are no longer linking MKL to the MKL-DNN/oneDNN build Differential Revision: D25514612 fbshipit-source-id: d0f52bced60c5265f322f80363bd888e3d50ab5a
jacobkahn
added a commit
to jacobkahn/flashlight
that referenced
this pull request
Dec 12, 2020
Summary: Pull Request resolved: flashlight#330 Fix the Docker image build - Use multiple `RUN` commands with `docker prune` to allow checkingpointing the base image builds to make it easier to debug stuff in the future - Make `MKLROOT` a global env var - Remove the MKL BLAS vendor for oneDNN (apparently faster without MKL) - see microsoft/vcpkg#15068 (comment) - Enable building tests in the CPU CI build since it works now and `gtest_discover_tests` is removed so we don't have runtime `libmlk_rt` issues. We also shouldn't have those issues anymore in general because we are no longer linking MKL to the MKL-DNN/oneDNN build Reviewed By: tlikhomanenko Differential Revision: D25514612 fbshipit-source-id: a14ba9113b7d3f36ecf9a7478613ec1354518458
facebook-github-bot
pushed a commit
to flashlight/flashlight
that referenced
this pull request
Dec 12, 2020
Summary: Pull Request resolved: #330 Fix the Docker image build - Use multiple `RUN` commands with `docker prune` to allow checkingpointing the base image builds to make it easier to debug stuff in the future - Make `MKLROOT` a global env var - Remove the MKL BLAS vendor for oneDNN (apparently faster without MKL) - see microsoft/vcpkg#15068 (comment) - Enable building tests in the CPU CI build since it works now and `gtest_discover_tests` is removed so we don't have runtime `libmlk_rt` issues. We also shouldn't have those issues anymore in general because we are no longer linking MKL to the MKL-DNN/oneDNN build Reviewed By: tlikhomanenko Differential Revision: D25514612 fbshipit-source-id: 9f371a24e8c4de0c6779092539ffc544eaf21812
JackBoosY
suggested changes
Dec 14, 2020
JackBoosY
approved these changes
Dec 15, 2020
jacobkahn
added a commit
to flashlight/text
that referenced
this pull request
Mar 25, 2022
Summary: Pull Request resolved: flashlight/flashlight#330 Fix the Docker image build - Use multiple `RUN` commands with `docker prune` to allow checkingpointing the base image builds to make it easier to debug stuff in the future - Make `MKLROOT` a global env var - Remove the MKL BLAS vendor for oneDNN (apparently faster without MKL) - see microsoft/vcpkg#15068 (comment) - Enable building tests in the CPU CI build since it works now and `gtest_discover_tests` is removed so we don't have runtime `libmlk_rt` issues. We also shouldn't have those issues anymore in general because we are no longer linking MKL to the MKL-DNN/oneDNN build Reviewed By: tlikhomanenko Differential Revision: D25514612 fbshipit-source-id: 9f371a24e8c4de0c6779092539ffc544eaf21812
jacobkahn
added a commit
to flashlight/text
that referenced
this pull request
Mar 25, 2022
Summary: Pull Request resolved: flashlight/flashlight#330 Fix the Docker image build - Use multiple `RUN` commands with `docker prune` to allow checkingpointing the base image builds to make it easier to debug stuff in the future - Make `MKLROOT` a global env var - Remove the MKL BLAS vendor for oneDNN (apparently faster without MKL) - see microsoft/vcpkg#15068 (comment) - Enable building tests in the CPU CI build since it works now and `gtest_discover_tests` is removed so we don't have runtime `libmlk_rt` issues. We also shouldn't have those issues anymore in general because we are no longer linking MKL to the MKL-DNN/oneDNN build Reviewed By: tlikhomanenko Differential Revision: D25514612 fbshipit-source-id: 9f371a24e8c4de0c6779092539ffc544eaf21812
jacobkahn
added a commit
to flashlight/sequence
that referenced
this pull request
Oct 13, 2022
Summary: Pull Request resolved: flashlight/flashlight#330 Fix the Docker image build - Use multiple `RUN` commands with `docker prune` to allow checkingpointing the base image builds to make it easier to debug stuff in the future - Make `MKLROOT` a global env var - Remove the MKL BLAS vendor for oneDNN (apparently faster without MKL) - see microsoft/vcpkg#15068 (comment) - Enable building tests in the CPU CI build since it works now and `gtest_discover_tests` is removed so we don't have runtime `libmlk_rt` issues. We also shouldn't have those issues anymore in general because we are no longer linking MKL to the MKL-DNN/oneDNN build Reviewed By: tlikhomanenko Differential Revision: D25514612 fbshipit-source-id: 9f371a24e8c4de0c6779092539ffc544eaf21812
jacobkahn
added a commit
to flashlight/sequence
that referenced
this pull request
Oct 13, 2022
Summary: Pull Request resolved: flashlight/flashlight#330 Fix the Docker image build - Use multiple `RUN` commands with `docker prune` to allow checkingpointing the base image builds to make it easier to debug stuff in the future - Make `MKLROOT` a global env var - Remove the MKL BLAS vendor for oneDNN (apparently faster without MKL) - see microsoft/vcpkg#15068 (comment) - Enable building tests in the CPU CI build since it works now and `gtest_discover_tests` is removed so we don't have runtime `libmlk_rt` issues. We also shouldn't have those issues anymore in general because we are no longer linking MKL to the MKL-DNN/oneDNN build Reviewed By: tlikhomanenko Differential Revision: D25514612 fbshipit-source-id: 9f371a24e8c4de0c6779092539ffc544eaf21812
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new port for the oneDNN deep learning library.
cc @vpirogov, @dzarukin, @echeresh, @mgouicem, @akharito, @densamoilov
cc @syhw, @padentomasello, @tlikhomanenko, @vineelpratap, @xuqiantong, @avidov
x64 & !uwp. Tested myself onx64-linux.Yes