Update CPU and CUDA Dockerfiles#330
Closed
jacobkahn wants to merge 1 commit intoflashlight:masterfrom
Closed
Conversation
Summary: Pull Request resolved: flashlight#330 Fix the Docker image build - Use multiple `RUN` commands with `docker prune` to allow checkingpointing the base image builds to make it easier to debug stuff in the future - Make `MKLROOT` a global env var - Remove the MKL BLAS vendor for oneDNN (apparently faster without MKL) - see microsoft/vcpkg#15068 (comment) - Enable building tests in the CPU CI build since it works now and `gtest_discover_tests` is removed so we don't have runtime `libmlk_rt` issues. We also shouldn't have those issues anymore in general because we are no longer linking MKL to the MKL-DNN/oneDNN build Reviewed By: tlikhomanenko Differential Revision: D25514612 fbshipit-source-id: a14ba9113b7d3f36ecf9a7478613ec1354518458
71d200b to
5e1006f
Compare
jacobkahn
added a commit
to flashlight/text
that referenced
this pull request
Mar 25, 2022
Summary: Pull Request resolved: flashlight/flashlight#330 Fix the Docker image build - Use multiple `RUN` commands with `docker prune` to allow checkingpointing the base image builds to make it easier to debug stuff in the future - Make `MKLROOT` a global env var - Remove the MKL BLAS vendor for oneDNN (apparently faster without MKL) - see microsoft/vcpkg#15068 (comment) - Enable building tests in the CPU CI build since it works now and `gtest_discover_tests` is removed so we don't have runtime `libmlk_rt` issues. We also shouldn't have those issues anymore in general because we are no longer linking MKL to the MKL-DNN/oneDNN build Reviewed By: tlikhomanenko Differential Revision: D25514612 fbshipit-source-id: 9f371a24e8c4de0c6779092539ffc544eaf21812
jacobkahn
added a commit
to flashlight/text
that referenced
this pull request
Mar 25, 2022
Summary: Pull Request resolved: flashlight/flashlight#330 Fix the Docker image build - Use multiple `RUN` commands with `docker prune` to allow checkingpointing the base image builds to make it easier to debug stuff in the future - Make `MKLROOT` a global env var - Remove the MKL BLAS vendor for oneDNN (apparently faster without MKL) - see microsoft/vcpkg#15068 (comment) - Enable building tests in the CPU CI build since it works now and `gtest_discover_tests` is removed so we don't have runtime `libmlk_rt` issues. We also shouldn't have those issues anymore in general because we are no longer linking MKL to the MKL-DNN/oneDNN build Reviewed By: tlikhomanenko Differential Revision: D25514612 fbshipit-source-id: 9f371a24e8c4de0c6779092539ffc544eaf21812
jacobkahn
added a commit
to flashlight/sequence
that referenced
this pull request
Oct 13, 2022
Summary: Pull Request resolved: flashlight/flashlight#330 Fix the Docker image build - Use multiple `RUN` commands with `docker prune` to allow checkingpointing the base image builds to make it easier to debug stuff in the future - Make `MKLROOT` a global env var - Remove the MKL BLAS vendor for oneDNN (apparently faster without MKL) - see microsoft/vcpkg#15068 (comment) - Enable building tests in the CPU CI build since it works now and `gtest_discover_tests` is removed so we don't have runtime `libmlk_rt` issues. We also shouldn't have those issues anymore in general because we are no longer linking MKL to the MKL-DNN/oneDNN build Reviewed By: tlikhomanenko Differential Revision: D25514612 fbshipit-source-id: 9f371a24e8c4de0c6779092539ffc544eaf21812
jacobkahn
added a commit
to flashlight/sequence
that referenced
this pull request
Oct 13, 2022
Summary: Pull Request resolved: flashlight/flashlight#330 Fix the Docker image build - Use multiple `RUN` commands with `docker prune` to allow checkingpointing the base image builds to make it easier to debug stuff in the future - Make `MKLROOT` a global env var - Remove the MKL BLAS vendor for oneDNN (apparently faster without MKL) - see microsoft/vcpkg#15068 (comment) - Enable building tests in the CPU CI build since it works now and `gtest_discover_tests` is removed so we don't have runtime `libmlk_rt` issues. We also shouldn't have those issues anymore in general because we are no longer linking MKL to the MKL-DNN/oneDNN build Reviewed By: tlikhomanenko Differential Revision: D25514612 fbshipit-source-id: 9f371a24e8c4de0c6779092539ffc544eaf21812
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fix the Docker image build
RUNcommands withdocker pruneto allow checkingpointing the base image builds to make it easier to debug stuff in the futureMKLROOTa global env vargtest_discover_testsis removed so we don't have runtimelibmlk_rtissues. We also shouldn't have those issues anymore in general because we are no longer linking MKL to the MKL-DNN/oneDNN buildDifferential Revision: D25514612