[vcpkg] Fix uploading to Azure DevOps Artifacts#14952
Merged
BillyONeal merged 5 commits intomicrosoft:masterfrom Dec 8, 2020
Merged
[vcpkg] Fix uploading to Azure DevOps Artifacts#14952BillyONeal merged 5 commits intomicrosoft:masterfrom
BillyONeal merged 5 commits intomicrosoft:masterfrom
Conversation
vicroms
approved these changes
Dec 5, 2020
BillyONeal
reviewed
Dec 6, 2020
BillyONeal
approved these changes
Dec 8, 2020
Member
|
Thanks for your contribution! |
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
|
It looks like this is broken again. Looking at the changes in this PR, it seems to be looking for the text "for example "-ApiKey AzureDevOps"" to determine when to insert the dummy key. But apparently, this has changed on the Azure Artifacts side, and the actual error you get back in this case doesn't contain that text. It instead says "No API Key was provided and no API Key could be found for..." |
Contributor
|
@jeffkohn-swi Can you please open a new issue to report that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes regression caused by #14202.
While ADO Artifacts supports downloading without an ApiKey, it does not support uploading. This PR detects the error message emitted by NuGet when attempting to upload to ADO and retries with the given dummy ApiKey (
AzureDevOps). Users using other servers can specify ApiKeys via thenugetconfigprovider or theSetApiKeyCLI command ofnuget.exe.As a drive by, the documentation on how to specify credentials for NuGet has been greatly expanded.
Fixes #14304. Fixes #14840.
@thomas-t1 @photex I'd appreciate it if you could confirm that this change fixes your respective issues :)