[vcpkg] Remove hard-coded ApiKey from nuget push#14202
Merged
ras0219-msft merged 1 commit intomicrosoft:masterfrom Oct 29, 2020
Merged
[vcpkg] Remove hard-coded ApiKey from nuget push#14202ras0219-msft merged 1 commit intomicrosoft:masterfrom
ras0219-msft merged 1 commit intomicrosoft:masterfrom
Conversation
ras0219
approved these changes
Oct 29, 2020
Contributor
ras0219
left a comment
There was a problem hiding this comment.
Thanks for using binary caching and extra thanks the fix!
I have tested this against ADO artifacts feeds and confirmed that it no longer needs an ApiKey parameter, so this LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
After experimenting with vcpkg binary caching feature and trying to upload the built binaries to GitHub Packages using NuGet, I ran into a similar authentication issue as #12984.
This PR removes the hard-coded NuGet API key so that a user's specified key can be used in a
VCPKG_BINARY_SOURCESenvironment variable.This was my first time using NuGet and setting everything up with GitHub Packages, so if this hard-coded key name is somehow intentional, I'd like to know how to work around this or what a better binary caching setup would look like.
What does your PR fix?
Fixes nugetconfig binary source ignores API key in config file #12984
Which triplets are supported/not supported? Have you updated the CI baseline?
N/A
Does your PR follow the maintainer guide?
Yes.