Skip to content

[cmake] update to 3.19.2#14716

Merged
BillyONeal merged 18 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/cmake_3.19.0
Dec 29, 2020
Merged

[cmake] update to 3.19.2#14716
BillyONeal merged 18 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/cmake_3.19.0

Conversation

@JackBoosY
Copy link
Copy Markdown
Contributor

@JackBoosY JackBoosY commented Nov 23, 2020 •
edited
Loading

Update to 3.19.1

@JackBoosY JackBoosY added info:internal category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly labels Nov 23, 2020
@JackBoosY JackBoosY mentioned this pull request Nov 23, 2020
Closed
@JackBoosY JackBoosY added the depends:vm-update PR contains changes to the VM provisioning scripts label Nov 23, 2020
@traversaro
Copy link
Copy Markdown
Contributor

traversaro commented Nov 23, 2020

In CMake 3.19.0 there is a regression that may prevent to build LLVM, and will be fixed in CMake 3.19.1 : https://gitlab.kitware.com/cmake/cmake/-/issues/21469 .

@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Nov 23, 2020 •
edited
Loading

@traversaro 3.19.1 is not published on github.

@JackBoosY JackBoosY marked this pull request as draft November 23, 2020 08:53
@traversaro
Copy link
Copy Markdown
Contributor

traversaro commented Nov 23, 2020

@traversaro 3.19.1 is not published on github.

Yes, sorry for not being clear, but I meant that it will be fixed in 3.19.1 once it is released (in the future). Homebrew backported the fix for the time being, see Homebrew/homebrew-core#65416 .

@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Nov 23, 2020

@traversaro So this PR will wait for 3.19.1 published.

@JackBoosY JackBoosY added the depends:upstream-changes Waiting on a change to the upstream project label Nov 24, 2020
@traversaro
Copy link
Copy Markdown
Contributor

traversaro commented Nov 24, 2020

@traversaro So this PR will wait for 3.19.1 published.

CMake 3.19.1 was released today: https://discourse.cmake.org/t/cmake-3-19-1-available-for-download/2228 .

@JackBoosY JackBoosY removed the depends:upstream-changes Waiting on a change to the upstream project label Nov 25, 2020
@JackBoosY JackBoosY changed the title [cmake] update to 3.19.0 [cmake] update to 3.19.1 Nov 25, 2020
@JackBoosY JackBoosY mentioned this pull request Nov 26, 2020
Open
@JackBoosY JackBoosY mentioned this pull request Nov 26, 2020
Closed
@JackBoosY JackBoosY mentioned this pull request Nov 26, 2020
Closed
@JackBoosY JackBoosY mentioned this pull request Nov 26, 2020
Merged
@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Nov 30, 2020

Since there are many same regressions about cmake, I will continue this PR after https://discourse.cmake.org/t/error-when-installing-targets-and-exports-in-3-19-1/2245/6 discussion finished.

@JackBoosY JackBoosY added the depends:upstream-changes Waiting on a change to the upstream project label Dec 1, 2020
@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Dec 7, 2020

The official fixed this issue, waiting for the new version publish.

@orudge orudge mentioned this pull request Dec 8, 2020
Merged
@JackBoosY JackBoosY removed the depends:vm-update PR contains changes to the VM provisioning scripts label Dec 10, 2020
@JackBoosY JackBoosY removed the depends:upstream-changes Waiting on a change to the upstream project label Dec 21, 2020
@JackBoosY JackBoosY changed the title [cmake] update to 3.19.1 [cmake] update to 3.19.2 Dec 22, 2020
@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Dec 24, 2020

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 24, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY marked this pull request as ready for review December 25, 2020 02:54
@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Dec 28, 2020 

LINK : fatal error LNK1201: error writing to program database 'D:\buildtrees\itk\x86-windows-dbg\bin\ITKQuadEdgeMesh-5.1.pdb'; check for insufficient disk space, invalid path, or insufficient privilege

Should be a disk space issue.

@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Dec 28, 2020 

LINK : fatal error LNK1201: error writing to program database 'D:\buildtrees\itk\x86-windows-dbg\bin\ITKQuadEdgeMesh-5.1.pdb'; check for insufficient disk space, invalid path, or insufficient privilege

Should be a disk space issue.

I'm not sure where you saw this output but if there were disk space issues we would see them in the reports. For example x64-windows-static in the current build says:

Disk Label             Size    Free Space
---- -----             ----    ----------
C:   Windows           127 GiB 86 GiB
D:   Temporary Storage 400 GiB 390 GiB
E:                     0 B     0 B

before the build and

Disk Label             Size    Free Space
---- -----             ----    ----------
C:   Windows           127 GiB 86 GiB
D:   Temporary Storage 400 GiB 313 GiB
E:                     0 B     0 B

at the end of the build.

@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Dec 29, 2020

@BillyONeal Maybe because I reran the test.

@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Dec 29, 2020

libsigcpp:x86-windows: download issue. ITK regression did not appear.
Rerun the pipeline test now.

@BillyONeal BillyONeal added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 29, 2020
@BillyONeal BillyONeal mentioned this pull request Dec 29, 2020
Open
@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Dec 29, 2020

Robert looked at this and was OK with it but doesn't like the hdf5 related changes. I replied that these are similar to hdf5 related changes we have all over the rest of the tree and he was OK with that. I filed #15357 to track that work.

Will merge this once PR build passes.

@BillyONeal BillyONeal merged commit 8f8f716 into microsoft:master Dec 29, 2020
@JackBoosY JackBoosY deleted the dev/jack/cmake_3.19.0 branch December 29, 2020 05:41
ryukw7 pushed a commit to ryukw7/vcpkg that referenced this pull request Dec 29, 2020
@JackBoosY @BillyONeal
[cmake] update to 3.19.2 (microsoft#14716)
fb88e9e 
* [cmake] update to 3.19.0

* update vmss

* [cmake] update to 3.19.1

* [solid3] Fix configure error, fix static definition

* [flann] Add feature hdf5 and fix it

* [highfive] Fix dependency hdf5

* [simage] Fix configure error

* [aws-c-common] Fix configure error

* [cmake] Update to 3.19.2

* Revert changes about cmake bug

* [VMSS] Update cmake path on Windows

* [cmake] Update cmake hash

* [minc] Fix dependency hdf5

* [cmake] Update cmake package name and path on MacOS

Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
@traversaro traversaro mentioned this pull request Jan 9, 2021
Merged
@ianmcook ianmcook mentioned this pull request Jan 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels

category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JackBoosY @traversaro @BillyONeal @PhoebeHui