Skip to content

cmake: backport cmake patch (unblock #64836)#65416

Closed
jeroen wants to merge 1 commit intoHomebrew:masterfrom
jeroen:cmake
Closed

cmake: backport cmake patch (unblock #64836)#65416
jeroen wants to merge 1 commit intoHomebrew:masterfrom
jeroen:cmake

Conversation

@jeroen
Copy link
Copy Markdown
Contributor

@jeroen jeroen commented Nov 22, 2020 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Fixes a regression in the latest cmake that prevents some formulas from building.
This should unblock the protobuf migration in #64836 (comment)

@jeroen jeroen mentioned this pull request Nov 22, 2020
Closed
@jeroen jeroen changed the title backport cmake patch backport cmake patch (unblock #64836) Nov 22, 2020
@chenrui333 chenrui333 changed the title backport cmake patch (unblock #64836) cmake: backport cmake patch (unblock #64836) Nov 22, 2020
@chenrui333
Copy link
Copy Markdown
Member

chenrui333 commented Nov 22, 2020

Thanks @jeroen!

@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Nov 22, 2020

:shipit: @chenrui333 has triggered a merge.

@jeroen jeroen deleted the cmake branch November 22, 2020 21:48
@traversaro traversaro mentioned this pull request Nov 23, 2020
Merged
@selsta
Copy link
Copy Markdown
Contributor

selsta commented Nov 23, 2020

This patch should not apply when building HEAD.

@jeroen
Copy link
Copy Markdown
Contributor Author

jeroen commented Nov 23, 2020

It will be removed for the upcoming cmake 3.19.1 release.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 24, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees

No one assigned

Labels

outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jeroen @chenrui333 @BrewTestBot @selsta