protobuf 3.14.0#64836
protobuf 3.14.0#64836jeroen wants to merge 29 commits intoHomebrew:masterfrom jeroen:bump-protobuf-3.14.0
Conversation
|
|
|
Rebased for the updated grpc... |
|
|
We now see 2 errors in reverse dependencies which are unrelated protobuf. libphonenumber seems to have moved a tag: And it looks like libtorchvision has been compiled agains xQuartz (which is in /opt/X11) which is no longer available? Should I bump these as well, and rebuild again? |
|
For libphonenumber we should ask upstream if it was intentional, for torchvision we should figure out how to make it not do that. @gromgit might be able to help there. |
|
@jeroen, based on my local tests, |
|
@chenrui333 I think this is ready to merge. The only remaining error is: The upstream git repository doesn't have an issue tracker, but they seem to be creating and moving the latest tag as part of the release process to test release candidates. |
|
yeah, let's move forward with the change. |
|
|
|
|
Is it because opencv was updated between when yesterday and now? So we need to rebump the revision, even one more? |
|
yeah, that sounds about right, unfortunately. I just rebased and have another run before the merge. |
|
Hmm OK, I think the PR now no longer contains a bump to opencv, so it will probably fail for that... |
my bad |
|
This time should work. 🤞 |
|
🤞 |
|
👋 any word on when this will be deployed? |
Signed-off-by: Rui Chen <rui@meetup.com>
Signed-off-by: Rui Chen <rui@meetup.com>
Signed-off-by: Rui Chen <rui@meetup.com>
Signed-off-by: Rui Chen <rui@meetup.com>
Signed-off-by: Rui Chen <rui@meetup.com>
Signed-off-by: Rui Chen <rui@meetup.com>
Signed-off-by: Rui Chen <rui@meetup.com>
Signed-off-by: Rui Chen <rui@meetup.com>
|
merged the cmake fix and rebased the PR. 🤞 |
|
rerun the build because 10.14 build somehow got skipped previously. |
|
I will do the merge around lunch today. |
Can you try and contact them regardless? Maybe tagging some maintainers here? The git manual says re-tagging is "the insane thing" to do and it just causes a lot of trouble for everyone. |
|
Hi @rohininidhi or maybe @penmetsaa, 👋 we run into some libphonenumber audit check issue (since it got re-released?). Because there is no way for us to create an issue to track down on your side, I will tag you for clarifying the re-release is intentional for our better understanding the release process in general. Any feedback or comments are appreciated. Thanks!! |
|
|
|
|
|
Thanks @jeroen!! |
|
Thanks for your help! I think this issue shows that there is some room for improvement in the homebrew build process. Perhaps the CI could automatically bump the required bottles, such that the PR is not constantly outdated/blocked due to other things changing at the same time. |
Created with
brew bump-formula-pr.resourceblocks may require updates.