[llvm] Update to version 10.0.0 and add new features#10295
[llvm] Update to version 10.0.0 and add new features#10295strega-nil merged 24 commits intomicrosoft:masterfrom yurybura:llvm10
Conversation
|
Dear @PhoebeHui, could you help to solve Windows build-bot issue? LINK : fatal error LNK1201: error writing to program database 'C:\vsts_work\4\s\buildtrees\llvm\x64-windows-dbg\bin\llvm-dwp.pdb'; check for insufficient disk space, invalid path, or insufficient privilege LINK : fatal error LNK1102: out of memory LLVM is really big project. I can disable some features by default, but it isn't right way I think. Thank you! |
|
@strega-nil, could you help take a look at above issue? |
|
@yurybura, thanks for your contribution! Noted that the following triplets disabled on https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt#L1002, if you fix the issue with specific triplet, please remove it. llvm:arm64-windows=fail |
|
@PhoebeHui, let me try to fix failed CI checks. |
|
@PhoebeHui, I've already tested my changes for x64-windows and x64-linux triplets on my local machine. Unfortunately I cannot test with CI bot... |
|
llvm is a complicated and big project, it brings a stress to CI test machines, @strega-nil, any suggestions about the issue? |
|
This PR is awesome, thanks for this PR! |
|
@PhoebeHui huh! Well, that's unfortunate. Lemme think about this! |
|
Note the other paths in the cmake file. |
[llvm] disable assertions and ABI breaking checks by default [llvm] limit the maximum number of concurrent link jobs to 1 [llvm] add postfix `d` and debug shared libraries in the `/bin` directory
[llvm] don't remove debug version of tools and shared libs
|
@yurybura -- Thank you so much for your work on this! I'm with the Halide project and (among other things) am working on improving our build on Windows. This is a huge help. |
|
This is extremely exciting! I'm hopeful we can merge today :3 |
|
Is this PR ready to be merged? I have a project that needs LLVM-10, and it would be great to vcpkg to handle this dependency! Thanks for all your hard work btw |
Ditto! Happy to lend a hand any way I can to grease the skids here, too 🙂 |
|
Ah, sorry! I got distracted and forgot to hit the button... unfortunately I'm still learning the ropes -.- |
No, no, thank you so much! This is a big help to me and my team! |
[llvm] Update to version 10.0.0 and add new features (microsoft#10295)
|
sadly, llvm is broken on Linux now. |
|
@cenit looks like running out of space, so I'm gonna rerun it. This is the issue with LLVM |
|
It’s broken also on my local machine now. Still not investigated the reason, but for sure not disk space |
|
That's really odd... I'm looking into it |
|
My local build works fine. Debug build log is attached: @cenit Could you attach your log? |
|
Sorry I lost logs in the update (last step is cleanup of buildtrees folder in any case). In case the same problem happens again, tonight, I will let you know. Seeing that it was broken also on master made me maybe too quick to think it was this PR fault. Maybe it was just a double coincidence (two different unrelated problems here and on my machine) |
|
re-launched manually to have logs sooner. Build fails very soon, here it is the Distributor ID: Ubuntu |
|
It's working on my machine... how do you run the build, and what are your environment variables? |
|
Under the hypothesis that it failed in CI due to the OOM killer, this makes the test VMs have more RAM: #11174 (The PR infrastructure under which this PR passed had half as much RAM per core) |
|
The LLVM in the new infra is now failing in the same way as in @cenit's case. This is really, really weird. |
|
Considering it turns out not to be the OOM killer and we have direct customer feedback of it being broken on their machine, should we back this out? |
|
Yeah, I guess so. I don't like having such an old version, but we can at least try and figure out why it's broken. |
|
For me it's ok to just wait a little bit and have llvm 10 properly installed. It just depends on timing, maybe @yurybura can help? |
|
@cenit Your issue is related to the external dependency to the libxml2. It easy to fix, but I need full CMake log. This is CMake configuration issue. |
|
@cenit @BillyONeal @strega-nil I found the full log in the PR #11174. Let me try to fix it. |
|
thank you. I'd really like to help you but I am really very constrained with time... sorry |
|
@cenit @BillyONeal @strega-nil Please review/merge my fix in the PR #11180. |
LLVM 10 release is coming soon.
So, this PR updates LLVM to 10.0.0 version.
Other changes:
Related to #8521
Fixes #3377
Fixes #4277
Fixes #4461
Fixes #5153
Fixes #8347
Fixes #8463
Fixes #9670