[vcpkg] [llvm] Bump Linux VM memory size and do all operations on the temporary disk.#11174
Conversation
|
@ras0219-msft Do the qt failures look like the -j change? |
|
@Neumann-A Do those qt project failures look like fallout from the -j change that our binary caching scheme hid? |
|
@BillyONeal. Could be. I remember seeing that failure once but cannot remember if the fix was to remove the -j flag. I tried finding a commit which added and then removed the -j flag but couldn't find it. in the qt_(release|debug).conf with absolute paths to the right directory. It could also be that something else is wrong in the qt.conf but this would be surprising since the build without -j does work. |
a22bad5 to
afd504a
Compare
|
/azp run microsoft.vcpkg.clean-tombstones |
|
No pipelines are associated with this pull request. |
|
/azp help |
Supported commands
See additional documentation. |
|
/azp list |
|
CI/CD Pipelines for this repository: |
|
/azp list |
|
CI/CD Pipelines for this repository: |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@BillyONeal Looks like LLVM is now working! but qt5 still isn't >.< |
|
There are probably races in qt's bits, I just tried installing these locally and they worked :(. So I'll need to revert that :/ |
Yeah a problem I know too well. CI fails but locally everything works fine. Did you try it in WSL or real Linux? Was there any speed improvement with the -j flag ? |
|
@Neumann-A I used real Linux. It cut build time for the entire ports tree almost in half. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hmm any way for me to force the failure in CI via a PR or is there no way to do it in a single PR? |
|
@Neumann-A I don't know of a good way to force it, no. I'm going to try one more thing before backing the change out completely... |
|
@BillyONeal Maybe add a ENV variable for it ENV{VCPKG_X_DISABLE_PARALLEL_QT}. So Users still benefit from it but you can disable it in CI. |
|
@Neumann-A If it's going to sporadically fail in CI that means it can for users too and we should back it out. I'm trying a complete archives rebuild in case some of the previous builds were wrong due to the missing disable parallel switch. We'll see how it goes. If that still fails I'm going to revert completely. |
But if there is never an error nobody will try to fix it or will try to add the parallel flag again and we probably won't remember the issue. If we have the escape hatch users which have the issue can use |
|
Now we're seeing flaky behavior on Windows so I'm totally reverting that :/ |
Nothing Qt can be blamed for. |
6c66496 to
8267a78
Compare
|
@Neumann-A Well looks like it wasn't the -j. Any ideas? |
8267a78 to
534ee26
Compare
|
@Neumann-A I think I know why it's broken. The qt scripts are trying to form a relative path from the installed directory to the packages directory, which doesn't work when they're both symlinks like this change does. |
|
@BillyONeal: Maybe try asking @Rastaban if he remembers the cannot find mkspec error on linux and changed something in the CI to make it work. Alternatively you could try to make all paths in vcpkg/ports/qt5-base/cmake/configure_qt.cmake Lines 120 to 132 in aa0b9d7 (or replace them with a manually written one for testing) |
|
@Neumann-A I tried an alternate method of getting work running in /mnt which doesn't need to create individual symlinks, we'll see if that works. |
ad3c748 to
21d2c86
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
21d2c86 to
d36a421
Compare
5f1739a to
13b9060
Compare
13b9060 to
dc2d35a
Compare
Uh oh!
There was an error while loading. Please reload this page.