Add support for the `win` key in keybindings by zadjii-msft · Pull Request #9783 · microsoft/terminal

zadjii-msft · 2021-04-12T11:07:40Z

Summary of the Pull Request

Does what it says on the can. People can now use win in a keybinding to
indicate that the chord needs win.

References

Done for Feature request: hot key drop down ala quake/guake/tilda #653
See also [MEGATHREAD] Quake Mode & Global Summon #8888

PR Checklist

Closes Consider adding support for win in key bindings? #3184
I work here
Tests added/passed
Requires documentation to be updated

Detailed Description of the Pull Request / Additional comments

For the record, I hate this. But it's great for quake mode, so meh. There's
shockingly more win keys claimed then you think - many more than the shortcut
guide even shows.

win+b: Focus the tray?
win+t: Focus the taskbar
win+p: Project...
win+c: The powertoys color picker
win+v: cloud clipboard

So the list of valid combos is vanishingly small. It's all about that win+~

Validation Steps Performed

Bound

        { "keys": [ "win+`" ], "command": "commandPalette" },

and yea, it works as expected

For the record, I hate this. But it's great for quake mode, so _meh_. There's shockingly more win keys claimed then you think - many more than the shortcut guide even shows.

github-actions · 2021-04-12T11:11:14Z

Misspellings found, please review:

valuse

To accept these changes, run the following commands from this repository on this branch

pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect/alphabet.txt
.github/actions/spelling/expect/expect.txt
.github/actions/spelling/expect/web.txt"');
@ARGV=@expect_files;
my @stale=qw('"aef aspnet boostorg BSODs Cac COINIT dahall DEFAPP DEFCON fde fea fmtlib HPCON isocpp mintty msvcrtd NVDA pinam QOL remoting Unk unte vcrt what3words xamarin "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect/b310b1cffc5df62f652ab1781d282ccfac3bb050.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling/expect";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"cac coinit defapp hpcon MSVCRTD Remoting unk valuse "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

✏️ Contributor please read this

By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.

⚠️ The command is written for posix shells. You can copy the contents of each perl command excluding the outer ' marks and dropping any '"/"' quotation mark pairs into a file and then run perl file.pl from the root of the repository to run the code. Alternatively, you can manually insert the items...

If the listed items are:

... misspelled, then please correct them instead of using the command.
... names, please add them to .github/actions/spelling/dictionary/names.txt.
... APIs, you can add them to a file in .github/actions/spelling/dictionary/.
... just things you're using, please add them to an appropriate file in .github/actions/spelling/expect/.
... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in .github/actions/spelling/patterns/.

See the README.md in each directory for more information.

🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉

🗜️ If you see a bunch of garbage and it relates to a binary-ish string, please add a file path to the .github/actions/spelling/excludes.txt file instead of just accepting the garbage.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

DHowett · 2021-04-12T15:21:03Z

it actually works??? this is great

doc/cascadia/profiles.schema.json

src/cascadia/TerminalControl/KeyChord.idl

carlos-zamora · 2021-04-12T17:50:20Z

I'll let you/Michael figure out the regex thing. But don't forget to update the docs plz. We probably want some kind of warning in the docs too.

zadjii-msft · 2021-04-13T17:08:33Z

TODO:

ConvertVKModifiers needs win too!
Will this affect Do not dismiss selection if the Windows keys is pressed as a key-combination #9163?

Don-Vito · 2021-04-13T22:31:56Z

@zadjii-msft - will it affect #9163?

zadjii-msft · 2021-04-14T11:07:07Z

@zadjii-msft - will it affect #9163?

Oh, this, might. I'll take a look. Thanks!

miniksa

Marking req changes until the regex is sussed out.

…eybindings

…negative look behind at all

zadjii-msft · 2021-04-14T20:29:56Z

Works in the flyout:

and cmdpal:

And it doesn't dismiss the selection ✔️ (or rather, win+shift+s still works the same)

zadjii-msft · 2021-04-14T21:19:02Z

dev/migrie/f/653-QUAKE-MODE is ready to send once this merges (QUAKE-MODE has some of this win key code that needs to get the updates from this branch).

ghost · 2021-04-15T16:52:23Z

Hello @miniksa!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

## Summary of the Pull Request Does what it says on the can. People can now use `win` in a keybinding to indicate that the chord needs <kbd>win</kbd>. ## References * Done for microsoft#653 * See also microsoft#8888 ## PR Checklist * [x] Closes microsoft#3184 * [x] I work here * [ ] Tests added/passed * [ ] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments For the record, I hate this. But it's great for quake mode, so _meh_. There's shockingly more win keys claimed then you think - many more than the shortcut guide even shows. * `win+b`: Focus the tray? * `win+t`: Focus the taskbar * `win+p`: Project... * `win+c`: The powertoys color picker * `win+v`: cloud clipboard So the list of valid combos is vanishingly small. It's all about that <kbd>win+~</kbd> ## Validation Steps Performed Bound ```json { "keys": [ "win+`" ], "command": "commandPalette" }, ``` and yea, it works as expected

ghost · 2021-05-25T19:10:06Z

🎉Windows Terminal Preview v1.9.1445.0 has been released which incorporates this pull request.:tada:

Handy links:

zadjii-msft added 2 commits April 9, 2021 07:20

Add support for the win key in keybindings

10ea533

This actually allows win to be used successfully in a keybinding

26ba407

For the record, I hate this. But it's great for quake mode, so _meh_. There's shockingly more win keys claimed then you think - many more than the shortcut guide even shows.

ghost added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Apr 12, 2021

DHowett reviewed Apr 12, 2021

View reviewed changes

doc/cascadia/profiles.schema.json Outdated Show resolved Hide resolved

DHowett approved these changes Apr 12, 2021

View reviewed changes

src/cascadia/TerminalControl/KeyChord.idl Show resolved Hide resolved

zadjii-msft mentioned this pull request Apr 12, 2021

[MEGATHREAD] Quake Mode & Global Summon #8888

Open

61 tasks

zadjii-msft self-assigned this Apr 13, 2021

miniksa requested changes Apr 14, 2021

View reviewed changes

ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 14, 2021

zadjii-msft added 2 commits April 14, 2021 14:41

Merge remote-tracking branch 'origin/main' into dev/migrie/f/win-in-k…

5eb94ac

…eybindings

Use the regex from @miniksa, though I'm not sure vscode supports the …

4cfc4c2

…negative look behind at all

ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 14, 2021

The last stragglers of this PR

158ace3

zadjii-msft assigned miniksa and unassigned zadjii-msft Apr 14, 2021

miniksa approved these changes Apr 15, 2021

View reviewed changes

miniksa removed their assignment Apr 15, 2021

miniksa added the AutoMerge Marked for automatic merge by the bot when requirements are met label Apr 15, 2021

ghost merged commit eddb99e into main Apr 15, 2021

ghost deleted the dev/migrie/f/win-in-keybindings branch April 15, 2021 16:52

zadjii-msft mentioned this pull request Apr 20, 2021

Split TermControl into a Core, Interactivity, and Control layer #9820

Merged

5 tasks

ghost mentioned this pull request May 25, 2021

Consider adding support for win in key bindings? #3184

Closed

KalleOlaviNiemitalo mentioned this pull request Jul 19, 2021

Regex backreference does not count named groups even with RegexOptions.ECMAScript, but ECMA-262 does dotnet/runtime#43771

Open

zadjii-msft mentioned this pull request Mar 22, 2024

Add windows key support for key bindings #16909

Closed

j4james mentioned this pull request Jun 23, 2024

Windows key doesn't work when assigning key actions #17437

Open

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for the `win` key in keybindings#9783

Add support for the `win` key in keybindings#9783
5 commits merged intomainfrom
dev/migrie/f/win-in-keybindings

zadjii-msft commented Apr 12, 2021

Uh oh!

github-actions bot commented Apr 12, 2021

Uh oh!

DHowett commented Apr 12, 2021

Uh oh!

Uh oh!

Uh oh!

carlos-zamora commented Apr 12, 2021

Uh oh!

zadjii-msft commented Apr 13, 2021 •

edited

Loading

Uh oh!

Don-Vito commented Apr 13, 2021

Uh oh!

zadjii-msft commented Apr 14, 2021

Uh oh!

miniksa left a comment

Uh oh!

zadjii-msft commented Apr 14, 2021

Uh oh!

zadjii-msft commented Apr 14, 2021

Uh oh!

ghost commented Apr 15, 2021

Uh oh!

ghost commented May 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

zadjii-msft commented Apr 12, 2021

Summary of the Pull Request

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Uh oh!

github-actions bot commented Apr 12, 2021

Misspellings found, please review:

Uh oh!

DHowett commented Apr 12, 2021

Uh oh!

Uh oh!

Uh oh!

carlos-zamora commented Apr 12, 2021

Uh oh!

zadjii-msft commented Apr 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO:

Uh oh!

Don-Vito commented Apr 13, 2021

Uh oh!

zadjii-msft commented Apr 14, 2021

Uh oh!

miniksa left a comment

Choose a reason for hiding this comment

Uh oh!

zadjii-msft commented Apr 14, 2021

Uh oh!

zadjii-msft commented Apr 14, 2021

Uh oh!

ghost commented Apr 15, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

ghost commented May 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zadjii-msft commented Apr 13, 2021 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.