Do not dismiss selection if the Windows keys is pressed as a key-combination#9163
Merged
6 commits merged intomicrosoft:mainfrom Feb 17, 2021
Merged
Conversation
Get changes from main repo
microsoft#8791. Don't dismiss selection if Windows key was also pressed.
Remove trailing whitespace
Clear whitespace in empty line
Revise code for better abstraction & readability
Don-Vito
approved these changes
Feb 15, 2021
Contributor
Don-Vito
left a comment
There was a problem hiding this comment.
Not an expert, but besides a nit looks good to me! 😊
Probably, not as a part of this PR, we should also prevent the winkey combinations from scrolling (inside Terminal::SendKeyEvent)
zadjii-msft
approved these changes
Feb 17, 2021
|
Hello @carlos-zamora! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
DHowett
pushed a commit
that referenced
this pull request
Feb 23, 2021
…ination (#9163) Aims to fix #8791. <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Prior to this PR, if the Windows key was pressed as a part of a key combination, then selection was being dismissed. For example, when a user pressed `Windows` + `Shift` + `S` keys to invoke the _Capture & Annotate_ tool. This PR adds an exception for not clearing selection when either of the two Windows keys are pressed as part of a key combination. It was tested manually by trying to reproduce the issue. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #8791 * [x ] CLA signed. * [x ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #8791 <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed 1. Build Terminal. 2. Write anything & make a selection. 3. Press `Windows`+ `Shift` + `S` keys. 4. The _Capture & Annotate_ tool appears but the selection made in step 2 isn't dismissed (doesn't disappear). (cherry picked from commit 7d37ba2)
|
🎉 Handy links: |
|
🎉 Handy links: |
4 tasks
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aims to fix #8791.
Summary of the Pull Request
Prior to this PR, if the Windows key was pressed as a part of a key combination, then selection was being dismissed. For example, when a user pressed
Windows+Shift+Skeys to invoke the Capture & Annotate tool.This PR adds an exception for not clearing selection when either of the two Windows keys are pressed as part of a key combination.
It was tested manually by trying to reproduce the issue.
PR Checklist
Validation Steps Performed
Windows+Shift+Skeys.