Skip to content

Default to msbuild.exe on PATH if found#9

Merged
khouzam merged 1 commit intomicrosoft:masterfrom
dpodder:use-default-msbuild
Aug 14, 2017
Merged

Default to msbuild.exe on PATH if found#9
khouzam merged 1 commit intomicrosoft:masterfrom
dpodder:use-default-msbuild

Conversation

@dpodder
Copy link

@dpodder dpodder commented Aug 13, 2017

If msbuild is already on PATH, use that one instead of searching through known install locations. This way, if a user or contributor has already added msbuild to PATH (e.g. by running from a "Developer Command Prompt" for VS 2015 or 2017), the build uses the expected version of the tools.

@msftclas
Copy link

@dpodder,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@khouzam khouzam merged commit 1a6f3f8 into microsoft:master Aug 14, 2017
@dpodder dpodder deleted the use-default-msbuild branch August 18, 2017 13:06
miniksa pushed a commit that referenced this pull request Oct 4, 2019
Unify input handling across terminal implementations
Copilot AI added a commit to hoodini/terminal that referenced this pull request Dec 23, 2025
- Use "first strong character" heuristic per UAX microsoft#9 for paragraph direction
- Check LTR characters (A-Z, a-z) before RTL characters
- Extend RTL support to Hebrew (U+0590-U+05FF) and Arabic (U+0600-U+06FF)
- Fix SetBidiLevel to handle overlapping ranges from different segmentation
- Update documentation to reflect BiDi algorithm and expanded RTL support

Addresses review feedback on GetParagraphReadingDirection and SetBidiLevel.

Co-authored-by: hoodini <48050809+hoodini@users.noreply.github.com>
hoodini added a commit to hoodini/terminal that referenced this pull request Dec 23, 2025
Add RTL support for Hebrew and Arabic via Unicode BiDi Algorithm (UAX microsoft#9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants