Python: mypy and tests for OpenAI #7144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Collaborator
|
By the time we create a PR from this draft, I really hope the motivation & context section can be more than two words. :) |
moonbox3
approved these changes
Jul 8, 2024
854571b to
8e274f2
Compare
TaoChenOSU
reviewed
Jul 9, 2024
python/semantic_kernel/connectors/ai/open_ai/services/open_ai_chat_completion.py
Outdated
Show resolved
Hide resolved
TaoChenOSU
reviewed
Jul 9, 2024
python/semantic_kernel/connectors/ai/open_ai/services/open_ai_chat_completion_base.py
Show resolved
Hide resolved
47660e1 to
ee3e849
Compare
7 tasks
moonbox3
approved these changes
Jul 10, 2024
TaoChenOSU
approved these changes
Jul 10, 2024
ee3e849 to
a507d4a
Compare
moonbox3
approved these changes
Jul 11, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
### Motivation and Context 1. I saw that you are having spikes regarding enabling MyPy 2. On ##7049 i had the Liskov Principle commented 3. In #7144 is saw how you plan to solve this so i decided to adjust the mistral connector to this ### Description The PR contains changes to be compliant to MyPy in Mistral AI Connector. Changes input Parameter for MistralAIChatCompletion from MistralAIPromptExecutionSettings to PromptExecutionSettings. Adding Test Cases for MistralAIPromptExecutionSettings and PromptExecutionSettings.  ### Tasks - [x] Changes input Parameter for Liskov - [x] Settings conversion - [x] Adjust TestCases to 100% ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Nico Möller <nicomoller@microsoft.com> Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Up until this point, we had not had full test coverage for all openai classes, and mypy type checking was disabled. These have now both been solved, lots of small fixes for the typing and a set of new tests for the different parts of the openai suite of classes have been added. fixes microsoft#7131 fixes microsoft#6930 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> The unit tests for OpenAI all now have multiple ways of creating checked and tested. Also actual responses from the openai package are created and used to test the parsing of those into our classes. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
### Motivation and Context 1. I saw that you are having spikes regarding enabling MyPy 2. On #microsoft#7049 i had the Liskov Principle commented 3. In microsoft#7144 is saw how you plan to solve this so i decided to adjust the mistral connector to this ### Description The PR contains changes to be compliant to MyPy in Mistral AI Connector. Changes input Parameter for MistralAIChatCompletion from MistralAIPromptExecutionSettings to PromptExecutionSettings. Adding Test Cases for MistralAIPromptExecutionSettings and PromptExecutionSettings.  ### Tasks - [x] Changes input Parameter for Liskov - [x] Settings conversion - [x] Adjust TestCases to 100% ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Nico Möller <nicomoller@microsoft.com> Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Up until this point, we had not had full test coverage for all openai classes, and mypy type checking was disabled.
These have now both been solved, lots of small fixes for the typing and a set of new tests for the different parts of the openai suite of classes have been added.
fixes #7131
fixes #6930
Description
The unit tests for OpenAI all now have multiple ways of creating checked and tested.
Also actual responses from the openai package are created and used to test the parsing of those into our classes.
Contribution Checklist