Python: #6499 Mistral AI Chat Completion #7049

nmoeller · 2024-07-02T12:09:44Z

Motivation and Context

Why is this changed required ?
To enable Mistral Models with Semantic Kernel, there was the issue Python: Add Mistral AI Connector #6499 in the Backlog to add a MistralAI Connector
What problem does it solve ?
It solves the problem, that semantic kernel is not yet integrated with MistralAI
What scenario does it contribute to?
The scenario is to use different connector than HF,OpenAI or AzureOpenAI. When User's want to use Mistral they can easliy integrate it now
If it fixes an open issue, please link to the issue here.
Python: Add Mistral AI Connector #6499

Description

The changes made are designed by the open_ai connector, i tried to stay as close as possible to the structure.
For the integration i installed the mistral python package in the repository.

I added the following Classes :

MistrealAIChatPromptExcecutionSettings --> Responsible to administrate the Prompt Execution against MistralAI
MistralAIChatCompletion --> Responsible to coordinate the Classes and for Content parsing
MistralAISettings --> Basic Settings to work with the MistralAIClient

To test the changes with the tests please add MISTRALAI_API_KEY and MISTRALAI_CHAT_MODEL_ID as Enviorment Variable

From a design decision i moved the processing of Functions from Connectors to the ChatCompletionClientBaseClass

What is integrated yet :

Integrate Mistral AI ChatCompletion Models without Streaming
Integrate Mistral AI Chat Completion Models with Streaming
Simple Integration Test to test Streaming and non Streaming
Extended Testing including Unit Testing & More Integration Tests

Contribution Checklist

The code builds clean without any errors or warnings
The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
All unit tests pass, and I have added new tests where possible
I didn't break anyone 😄

markwallace-microsoft · 2024-07-02T12:10:17Z

Python 3.10 Test Coverage Report •

File	Stmts	Miss	Cover	Missing
TOTAL	6519	763	88%

report-only-changed-files is enabled. No files were changed during this commit :)

Python 3.10 Unit Test Overview

Tests	Skipped	Failures	Errors	Time
1558	1 💤	0 ❌	0 🔥	27.281s ⏱️

nmoeller · 2024-07-02T12:17:16Z

As commented on #6921, i decided to split the PR's into a more Lightweight PR and then increase the connector.

python/pyproject.toml

python/semantic_kernel/connectors/ai/mistral_ai/services/mistral_ai_chat_completion.py

moonbox3 · 2024-07-02T14:37:55Z

Hi @nmoeller, we just merged a PR that messed with the python/tests/conftest.py, so please have a look to resolve conflicts. Thanks.

…-Connector-chat-completion

nmoeller · 2024-07-02T14:49:04Z

Hi @nmoeller, we just merged a PR that messed with the python/tests/conftest.py, so please have a look to resolve conflicts. Thanks.

@moonbox3 I merged with the latest changes of the main Branch

...l/connectors/ai/mistral_ai/prompt_execution_settings/mistral_ai_prompt_execution_settings.py

moonbox3

LGTM. Thanks for working on this!

…ps://github.com/nmoeller/semantic-kernel into issue-6499-Mistral-Ai-Connector-chat-completion

juliomenendez

Looks good! Just a few minor comments.

python/semantic_kernel/connectors/ai/mistral_ai/services/mistral_ai_chat_completion.py

eavanvalkenburg

Lgtm!

python/pyproject.toml

python/samples/concepts/chat_completion/chat_mistral_api.py

…ps://github.com/nmoeller/semantic-kernel into issue-6499-Mistral-Ai-Connector-chat-completion

### Motivation and Context 1. I saw that you are having spikes regarding enabling MyPy 2. On ##7049 i had the Liskov Principle commented 3. In #7144 is saw how you plan to solve this so i decided to adjust the mistral connector to this ### Description The PR contains changes to be compliant to MyPy in Mistral AI Connector. Changes input Parameter for MistralAIChatCompletion from MistralAIPromptExecutionSettings to PromptExecutionSettings. Adding Test Cases for MistralAIPromptExecutionSettings and PromptExecutionSettings. ![image](https://github.com/microsoft/semantic-kernel/assets/23048106/5822896e-17d1-4d68-9348-da6765ac3527) ### Tasks - [x] Changes input Parameter for Liskov - [x] Settings conversion - [x] Adjust TestCases to 100% ### Contribution Checklist  - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Nico Möller <nicomoller@microsoft.com> Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>

### Motivation and Context  1. Why is this changed required ? To enable Mistral Models with Semantic Kernel, there was the issue microsoft#6499 in the Backlog to add a MistralAI Connector 2. What problem does it solve ? It solves the problem, that semantic kernel is not yet integrated with MistralAI 3. What scenario does it contribute to? The scenario is to use different connector than HF,OpenAI or AzureOpenAI. When User's want to use Mistral they can easliy integrate it now 4. If it fixes an open issue, please link to the issue here. microsoft#6499 ### Description The changes made are designed by the open_ai connector, i tried to stay as close as possible to the structure. For the integration i installed the mistral python package in the repository. I added the following Classes : - MistrealAIChatPromptExcecutionSettings --> Responsible to administrate the Prompt Execution against MistralAI - MistralAIChatCompletion --> Responsible to coordinate the Classes and for Content parsing - MistralAISettings --> Basic Settings to work with the MistralAIClient **To test the changes with the tests please add MISTRALAI_API_KEY and MISTRALAI_CHAT_MODEL_ID as Enviorment Variable** From a design decision i moved the processing of Functions from Connectors to the ChatCompletionClientBaseClass What is integrated yet : - [X] Integrate Mistral AI ChatCompletion Models without Streaming - [X] Integrate Mistral AI Chat Completion Models with Streaming - [X] Simple Integration Test to test Streaming and non Streaming - [x] Extended Testing including Unit Testing & More Integration Tests ### Contribution Checklist  - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄 --------- Co-authored-by: Nico Möller <nicomoller@microsoft.com>

### Motivation and Context 1. I saw that you are having spikes regarding enabling MyPy 2. On #microsoft#7049 i had the Liskov Principle commented 3. In microsoft#7144 is saw how you plan to solve this so i decided to adjust the mistral connector to this ### Description The PR contains changes to be compliant to MyPy in Mistral AI Connector. Changes input Parameter for MistralAIChatCompletion from MistralAIPromptExecutionSettings to PromptExecutionSettings. Adding Test Cases for MistralAIPromptExecutionSettings and PromptExecutionSettings. ![image](https://github.com/microsoft/semantic-kernel/assets/23048106/5822896e-17d1-4d68-9348-da6765ac3527) ### Tasks - [x] Changes input Parameter for Liskov - [x] Settings conversion - [x] Adjust TestCases to 100% ### Contribution Checklist  - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Nico Möller <nicomoller@microsoft.com> Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>

Added MistralAI ChatCompletion

f672801

nmoeller requested a review from a team as a code owner July 2, 2024 12:09

markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Jul 2, 2024

github-actions bot changed the title ~~#6499 Mistral AI Chat Completion~~ Python: #6499 Mistral AI Chat Completion Jul 2, 2024

eavanvalkenburg requested changes Jul 2, 2024

View reviewed changes

Integrated Feedback of PR

1155291

nmoeller requested review from eavanvalkenburg and moonbox3 July 2, 2024 14:36

Merge remote-tracking branch 'origin/main' into issue-6499-Mistral-Ai…

2a34856

…-Connector-chat-completion

moonbox3 reviewed Jul 2, 2024

View reviewed changes

...l/connectors/ai/mistral_ai/prompt_execution_settings/mistral_ai_prompt_execution_settings.py Outdated Show resolved Hide resolved

nmoellerms and others added 6 commits July 2, 2024 17:00

added mistral to unit test dependencies

27b7cbb

removed tools from settings

0ae805d

fixed comment and pytestfixture and lock file

6b2025f

adjusted test cases to not conatin tools

e986b01

handle function choice behavior

b6cc9e3

Merge branch 'main' into issue-6499-Mistral-Ai-Connector-chat-completion

29efd0b

moonbox3 approved these changes Jul 2, 2024

View reviewed changes

nmoellerms and others added 5 commits July 3, 2024 09:10

fixed mypy issues except liskov

11295d7

increased test coverage

a894710

Merge branch 'main' into issue-6499-Mistral-Ai-Connector-chat-completion

87a8a67

full test coverage

14218da

Merge branch 'issue-6499-Mistral-Ai-Connector-chat-completion' of htt…

0bebbf4

…ps://github.com/nmoeller/semantic-kernel into issue-6499-Mistral-Ai-Connector-chat-completion

moonbox3 approved these changes Jul 3, 2024

View reviewed changes

juliomenendez approved these changes Jul 3, 2024

View reviewed changes

eavanvalkenburg approved these changes Jul 3, 2024

View reviewed changes

python/pyproject.toml Show resolved Hide resolved

python/samples/concepts/chat_completion/chat_mistral_api.py Outdated Show resolved Hide resolved

Integrated PR Feedback and skip Int Tests if Mistral is not configured

46c997f

nmoeller and others added 4 commits July 4, 2024 09:01

Merge branch 'main' into issue-6499-Mistral-Ai-Connector-chat-completion

0ff93c8

small fix for skipping integration tests

b55ed11

Merge branch 'issue-6499-Mistral-Ai-Connector-chat-completion' of htt…

297373f

…ps://github.com/nmoeller/semantic-kernel into issue-6499-Mistral-Ai-Connector-chat-completion

Merge branch 'main' into issue-6499-Mistral-Ai-Connector-chat-completion

88ce112

moonbox3 approved these changes Jul 4, 2024

View reviewed changes

moonbox3 enabled auto-merge July 4, 2024 11:44

moonbox3 added this pull request to the merge queue Jul 4, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 4, 2024

nmoellerms and others added 3 commits July 4, 2024 14:26

skiped MistralConstructor in TestSetup

a5f8bea

Merge branch 'issue-6499-Mistral-Ai-Connector-chat-completion' of htt…

cda788c

…ps://github.com/nmoeller/semantic-kernel into issue-6499-Mistral-Ai-Connector-chat-completion

Merge branch 'main' into issue-6499-Mistral-Ai-Connector-chat-completion

a8e90ae

moonbox3 approved these changes Jul 4, 2024

View reviewed changes

moonbox3 enabled auto-merge July 4, 2024 12:34

moonbox3 added this pull request to the merge queue Jul 4, 2024

Merged via the queue into microsoft:main with commit ca7a58e Jul 4, 2024

nmoeller deleted the issue-6499-Mistral-Ai-Connector-chat-completion branch July 5, 2024 07:36

nmoeller mentioned this pull request Jul 10, 2024

Python : CQ MyPy Fix for MistralAI Connector #7182

Merged

7 tasks

Python: #6499 Mistral AI Chat Completion #7049

Python: #6499 Mistral AI Chat Completion #7049

Uh oh!

Conversation

nmoeller commented Jul 2, 2024

Motivation and Context

Description

Contribution Checklist

Uh oh!

markwallace-microsoft commented Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Python 3.10 Unit Test Overview

Uh oh!

nmoeller commented Jul 2, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

moonbox3 commented Jul 2, 2024

Uh oh!

nmoeller commented Jul 2, 2024

Uh oh!

Uh oh!

moonbox3 left a comment

Choose a reason for hiding this comment

Uh oh!

juliomenendez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eavanvalkenburg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

markwallace-microsoft commented Jul 2, 2024 •

edited

Loading