Java: Connectors - Memory - Unit test coverage #1598#1795
Merged
johnoliver merged 31 commits intomicrosoft:experimental-javafrom Jul 5, 2023
dsgrieve:dsgrieve/memory-unit-test-coverage
Merged
Java: Connectors - Memory - Unit test coverage #1598#1795johnoliver merged 31 commits intomicrosoft:experimental-javafrom dsgrieve:dsgrieve/memory-unit-test-coverage
johnoliver merged 31 commits intomicrosoft:experimental-javafrom
dsgrieve:dsgrieve/memory-unit-test-coverage
Conversation
### Motivation and Context ### Description Opening a PR with initial CI changes to build and run tests against Java packages. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: joe-braley <joebraley@microsoft.com> Co-authored-by: Luigi96 <luiseduardom@microsoft.com> Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Complete the implementation of VolatileMemoryStoreTests ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Complete the implementation of VolatileMemoryStoreTests. Make implementation consistent with tests. Please note that I added equals and hashCode methods to Embedding, MemoryRecord, and MemoryRecordMetadata because these unit tests use assertEquals. Alternatively, I could have created methods in VolatileMemoryStoreTests to check equality. I'm good with either way. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] ~The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format`~ Java code follows AOSP style - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
### Motivation and Context ### Description Add command to PRs to properly format Java code. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
…el into dsgrieve/memory-samples
…into experimental-java
…el into dsgrieve/memory-samples
…c-kernel into dsgrieve/memory-samples
…c-kernel into dsgrieve/memory-samples
…el into dsgrieve/memory-unit-test-coverage
…el into dsgrieve/memory-unit-test-coverage
dsgrieve
commented
Jun 30, 2023
...rosoft/semantickernel/connectors/memory/azurecognitivesearch/AzureCognitiveSearchMemory.java
Show resolved
Hide resolved
johnoliver
reviewed
Jul 5, 2023
...semantickernel-core/src/test/java/com/microsoft/semantickernel/memory/MemoryRecordTests.java
Show resolved
Hide resolved
johnoliver
approved these changes
Jul 5, 2023
Contributor
|
LGTM |
milderhc
approved these changes
Jul 5, 2023
Member
|
/spotless |
1 similar comment
Member
|
/spotless |
This was referenced Aug 1, 2023
johnoliver
added a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
…oft#1795) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Java: Connectors - Memory - Unit test coverage microsoft#1598 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Run unit tests with coverage and add additional tests to try to increase coverage. Added positive tests cases for AzureCognitiveSearchMemory. Negative tests and coverage need to be addressed. Because this is somewhat time consuming, I suggest that be done in a separate PR rather than hold this PR. I have created [Java: Increase coverage of AzureCognitiveSearchMemoryTests ](https://github.com/microsoft/semantic-kernel/issues/1797) for that purpose. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Luigi Montoya <yayodelta@gmail.com> Co-authored-by: joe-braley <joebraley@microsoft.com> Co-authored-by: Luigi96 <luiseduardom@microsoft.com> Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com> Co-authored-by: John Oliver <1615532+johnoliver@users.noreply.github.com>
johnoliver
added a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
…oft#1795) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Java: Connectors - Memory - Unit test coverage microsoft#1598 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Run unit tests with coverage and add additional tests to try to increase coverage. Added positive tests cases for AzureCognitiveSearchMemory. Negative tests and coverage need to be addressed. Because this is somewhat time consuming, I suggest that be done in a separate PR rather than hold this PR. I have created [Java: Increase coverage of AzureCognitiveSearchMemoryTests ](https://github.com/microsoft/semantic-kernel/issues/1797) for that purpose. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Luigi Montoya <yayodelta@gmail.com> Co-authored-by: joe-braley <joebraley@microsoft.com> Co-authored-by: Luigi96 <luiseduardom@microsoft.com> Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com> Co-authored-by: John Oliver <1615532+johnoliver@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Java: Connectors - Memory - Unit test coverage #1598
Description
Run unit tests with coverage and add additional tests to try to increase coverage.
Added positive tests cases for AzureCognitiveSearchMemory. Negative tests and coverage need to be addressed.
Because this is somewhat time consuming, I suggest that be done in a separate PR rather than hold this PR.
I have created Java: Increase coverage of AzureCognitiveSearchMemoryTests for that purpose.
Contribution Checklist
dotnet format