Skip to content

Java: VolatileMemoryStoreTests#1246

Merged
markwallace-microsoft merged 5 commits intomicrosoft:experimental-javafrom
dsgrieve:dsgrieve/memory-tests
Jun 2, 2023
Merged

Java: VolatileMemoryStoreTests#1246
markwallace-microsoft merged 5 commits intomicrosoft:experimental-javafrom
dsgrieve:dsgrieve/memory-tests

Conversation

@dsgrieve
Copy link
Contributor

@dsgrieve dsgrieve commented May 26, 2023

Motivation and Context

Complete the implementation of VolatileMemoryStoreTests

Description

Complete the implementation of VolatileMemoryStoreTests. Make implementation consistent with tests.

Please note that I added equals and hashCode methods to Embedding, MemoryRecord, and MemoryRecordMetadata because these unit tests use assertEquals. Alternatively, I could have created methods in VolatileMemoryStoreTests to check equality. I'm good with either way.

Contribution Checklist

@shawncal shawncal changed the title experimental-java: VolatileMemoryStoreTests Java: VolatileMemoryStoreTests May 27, 2023
@shawncal shawncal added the java Issue or PR regarding Java code label May 27, 2023
@dsgrieve dsgrieve marked this pull request as ready for review May 30, 2023 13:30
@markwallace-microsoft markwallace-microsoft merged commit 1fb4009 into microsoft:experimental-java Jun 2, 2023
@dsgrieve dsgrieve deleted the dsgrieve/memory-tests branch July 25, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java Issue or PR regarding Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants