Java: VolatileMemoryStoreTests#1246
Merged
markwallace-microsoft merged 5 commits intomicrosoft:experimental-javafrom Jun 2, 2023
dsgrieve:dsgrieve/memory-tests
Merged
Java: VolatileMemoryStoreTests#1246markwallace-microsoft merged 5 commits intomicrosoft:experimental-javafrom dsgrieve:dsgrieve/memory-tests
markwallace-microsoft merged 5 commits intomicrosoft:experimental-javafrom
dsgrieve:dsgrieve/memory-tests
Conversation
johnoliver
approved these changes
May 31, 2023
markwallace-microsoft
approved these changes
Jun 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Complete the implementation of VolatileMemoryStoreTests
Description
Complete the implementation of VolatileMemoryStoreTests. Make implementation consistent with tests.
Please note that I added equals and hashCode methods to Embedding, MemoryRecord, and MemoryRecordMetadata because these unit tests use assertEquals. Alternatively, I could have created methods in VolatileMemoryStoreTests to check equality. I'm good with either way.
Contribution Checklist
The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified withJava code follows AOSP styledotnet format