Copilot Chat: Multi-user support with SignalR by TaoChenOSU · Pull Request #1345 · microsoft/semantic-kernel

TaoChenOSU · 2023-06-05T18:48:04Z

Motivation and Context

Brings in support for multi-user chat experience with AI to Copilot Chat. This will further show case what we can build with SK and the power of Copilot in multi-user settings.

Description

Create ChatParticipant model to manage chat users.
Create FE and BE logic to allow users to join chats.
Use SignalR to achieve real time chatting experiences.
Documents permissions will remain in Chat level and Global level.
Plans can only be approved by the user who initiates the plans.
Permission for bot export/import will stay the same (i.e. anyone who is part of the chat can download a bot and anyone who has the Json can upload a bot).
Modify the prompts.

Note: we still need to work on prompt engineering to further improve the user experience with AI.

Contribution Checklist

The code builds clean without any errors or warnings
The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
All unit tests pass, and I have added new tests where possible
I didn't break anyone 😄

Combining and bringing in stage 1 of the multi user chat experience: - join chats via chat ids - signal R broadcasting from frontend and backend - signal R middleware - limit broadcasting to chat id groups - broadcast document uploading The code builds clean without any errors or warnings The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format All unit tests pass, and I have added new tests where possible I didn't break anyone 😄 --------- Co-authored-by: Tao Chen <TaoChenOSU@users.noreply.github.com> Co-authored-by: Tao Chen <taochen@microsoft.com>

### Motivation and Context  Dispatch returns immediately even when the action is captured by the SignalR middleware. ### Description  Dispatch the action to next() in the pipeline before the async logic in the middleware to make sure the stores are updated. ### Contribution Checklist  - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄

Need to show how many users are in a chat.  1. Create a widget in the Webapp that can show users that are part of the chat. This only shows user ids for now. 2. Broadcast to all chat members when a user joins. ![image](https://github.com/microsoft/semantic-kernel/assets/12570346/c63fd541-ffb4-4564-b020-20fdd728bbbe)  - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄

We need to know if someone or the bot is typing from the frontend. ![image](https://github.com/microsoft/semantic-kernel/assets/12570346/92002f11-9e12-429f-b0d1-72eedbe34fed)  Relay typing state through the backend.  - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄

samples/apps/copilot-chat-app/webapi/CopilotChat/Controllers/ChatHistoryController.cs

samples/apps/copilot-chat-app/webapp/src/components/chat/ChatInput.tsx

samples/apps/copilot-chat-app/webapi/CopilotChat/Controllers/ChatController.cs

samples/apps/copilot-chat-app/webapi/CopilotChat/Controllers/ChatHistoryController.cs

samples/apps/copilot-chat-app/webapi/CopilotChat/Controllers/ChatParticipantController.cs

samples/apps/copilot-chat-app/webapi/CopilotChat/Hubs/MessageRelayHub.cs

samples/apps/copilot-chat-app/webapi/CopilotChat/Storage/ChatParticipantRepository.cs

teresaqhoang

ReadMEs also need updated

And we should bug bash this as a team before it goes in

samples/apps/copilot-chat-app/webapp/src/App.tsx

samples/apps/copilot-chat-app/webapp/src/components/chat/ChatInput.tsx

...pps/copilot-chat-app/webapp/src/components/chat/invitation-dialog/InvitationCreateDialog.tsx

.../apps/copilot-chat-app/webapp/src/components/chat/invitation-dialog/InvitationJoinDialog.tsx

samples/apps/copilot-chat-app/webapp/src/redux/features/message-relay/signalRMiddleware.ts

.../apps/copilot-chat-app/webapp/src/components/chat/invitation-dialog/InvitationJoinDialog.tsx

samples/apps/copilot-chat-app/webapi/CopilotChat/Controllers/ChatController.cs

samples/apps/copilot-chat-app/webapi/CopilotChat/Controllers/ChatHistoryController.cs

samples/apps/copilot-chat-app/webapi/CopilotChat/Skills/ChatSkills/ChatSkill.cs

This reverts commit 18a35e5. We're seeing 401s after deployment.

#1534)" (#1556) This reverts commit 8357616 which re-merged multi-user Copilot Chat

### Motivation and Context  Brings in support for multi-user chat experience with AI to Copilot Chat. This will further show case what we can build with SK and the power of Copilot in multi-user settings. ### Description  1. Create ChatParticipant model to manage chat users. 2. Create FE and BE logic to allow users to join chats. 3. Use SignalR to achieve real time chatting experiences. 4. Documents permissions will remain in Chat level and Global level. 5. Plans can only be approved by the user who initiates the plans. 6. Permission for bot export/import will stay the same (i.e. anyone who is part of the chat can download a bot and anyone who has the Json can upload a bot). 7. Modify the prompts. Note: we still need to work on prompt engineering to further improve the user experience with AI. ![image](https://github.com/microsoft/semantic-kernel/assets/12570346/84d07b48-5bc5-44a4-8326-9f8007ece16a) ![image](https://github.com/microsoft/semantic-kernel/assets/12570346/58a14bb5-126f-4f14-870a-5837dccb9a5f) ![image](https://github.com/microsoft/semantic-kernel/assets/12570346/9d75b49b-d0a3-4bc4-8414-a288e68c92d4) ![image](https://github.com/microsoft/semantic-kernel/assets/12570346/48e4e6b6-2a7a-4675-a381-ce2e3ec5c8dc) ![image](https://github.com/microsoft/semantic-kernel/assets/12570346/9ab27650-ce40-479c-8834-e4b2f5caaccf) ### Contribution Checklist  - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Aman Sachan <51973971+amsacha@users.noreply.github.com> Co-authored-by: amsacha <amsacha@microsoft.com> Co-authored-by: Teresa Hoang <tehoang@microsoft.com> Co-authored-by: Teresa Hoang <125500434+teresaqhoang@users.noreply.github.com> Co-authored-by: Harleen Thind <39630244+hathind-ms@users.noreply.github.com> Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com>

…" (microsoft#1534) This reverts commit 18a35e5. We're seeing 401s after deployment.

### Motivation and Context  Brings in support for multi-user chat experience with AI to Copilot Chat. This will further show case what we can build with SK and the power of Copilot in multi-user settings. ### Description  1. Create ChatParticipant model to manage chat users. 2. Create FE and BE logic to allow users to join chats. 3. Use SignalR to achieve real time chatting experiences. 4. Documents permissions will remain in Chat level and Global level. 5. Plans can only be approved by the user who initiates the plans. 6. Permission for bot export/import will stay the same (i.e. anyone who is part of the chat can download a bot and anyone who has the Json can upload a bot). 7. Modify the prompts. Note: we still need to work on prompt engineering to further improve the user experience with AI. ![image](https://github.com/microsoft/semantic-kernel/assets/12570346/84d07b48-5bc5-44a4-8326-9f8007ece16a) ![image](https://github.com/microsoft/semantic-kernel/assets/12570346/58a14bb5-126f-4f14-870a-5837dccb9a5f) ![image](https://github.com/microsoft/semantic-kernel/assets/12570346/9d75b49b-d0a3-4bc4-8414-a288e68c92d4) ![image](https://github.com/microsoft/semantic-kernel/assets/12570346/48e4e6b6-2a7a-4675-a381-ce2e3ec5c8dc) ![image](https://github.com/microsoft/semantic-kernel/assets/12570346/9ab27650-ce40-479c-8834-e4b2f5caaccf) ### Contribution Checklist  - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Aman Sachan <51973971+amsacha@users.noreply.github.com> Co-authored-by: amsacha <amsacha@microsoft.com> Co-authored-by: Teresa Hoang <tehoang@microsoft.com> Co-authored-by: Teresa Hoang <125500434+teresaqhoang@users.noreply.github.com> Co-authored-by: Harleen Thind <39630244+hathind-ms@users.noreply.github.com> Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com>

…" (microsoft#1534) This reverts commit 18a35e5. We're seeing 401s after deployment.

…oft#1345)" (microsoft#1534)" (microsoft#1556) This reverts commit 8357616 which re-merged multi-user Copilot Chat

### Motivation and Context  Brings in support for multi-user chat experience with AI to Copilot Chat. This will further show case what we can build with SK and the power of Copilot in multi-user settings. ### Description  1. Create ChatParticipant model to manage chat users. 2. Create FE and BE logic to allow users to join chats. 3. Use SignalR to achieve real time chatting experiences. 4. Documents permissions will remain in Chat level and Global level. 5. Plans can only be approved by the user who initiates the plans. 6. Permission for bot export/import will stay the same (i.e. anyone who is part of the chat can download a bot and anyone who has the Json can upload a bot). 7. Modify the prompts. Note: we still need to work on prompt engineering to further improve the user experience with AI. ![image](https://github.com/microsoft/semantic-kernel/assets/12570346/84d07b48-5bc5-44a4-8326-9f8007ece16a) ![image](https://github.com/microsoft/semantic-kernel/assets/12570346/58a14bb5-126f-4f14-870a-5837dccb9a5f) ![image](https://github.com/microsoft/semantic-kernel/assets/12570346/9d75b49b-d0a3-4bc4-8414-a288e68c92d4) ![image](https://github.com/microsoft/semantic-kernel/assets/12570346/48e4e6b6-2a7a-4675-a381-ce2e3ec5c8dc) ![image](https://github.com/microsoft/semantic-kernel/assets/12570346/9ab27650-ce40-479c-8834-e4b2f5caaccf) ### Contribution Checklist  - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Aman Sachan <51973971+amsacha@users.noreply.github.com> Co-authored-by: amsacha <amsacha@microsoft.com> Co-authored-by: Teresa Hoang <tehoang@microsoft.com> Co-authored-by: Teresa Hoang <125500434+teresaqhoang@users.noreply.github.com> Co-authored-by: Harleen Thind <39630244+hathind-ms@users.noreply.github.com> Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com>

…" (microsoft#1534) This reverts commit e90daf2. We're seeing 401s after deployment.

…oft#1345)" (microsoft#1534)" (microsoft#1556) This reverts commit 7332556 which re-merged multi-user Copilot Chat

amsacha and others added 12 commits May 31, 2023 15:52

Extract Chat Participants from Chat History; Update Prompts;

e601b9c

update prompt

4c3712a

Merge branch 'main' into feature-copilotmultiuser

bb1e37f

Clean up prompt to extract audience

af6d48c

Fix Bot upload

7084f4d

Broadcast typing and bot responses to groups

6201a82

Plans can only be approved by the user who send the original msg

ca0970b

Merge branch 'main' into feature-copilotmultiuser

32027da

TaoChenOSU added PR: in progress Under development and/or addressing feedback samples labels Jun 5, 2023

TaoChenOSU requested review from Vivihung, adrianwyatt and teresaqhoang June 5, 2023 18:48

TaoChenOSU self-assigned this Jun 5, 2023

github-advanced-security bot found potential problems Jun 5, 2023

View reviewed changes

samples/apps/copilot-chat-app/webapi/CopilotChat/Controllers/ChatHistoryController.cs Fixed Show fixed Hide fixed

TaoChenOSU commented Jun 5, 2023

View reviewed changes

samples/apps/copilot-chat-app/webapp/src/components/chat/ChatInput.tsx Outdated Show resolved Hide resolved

TaoChenOSU added PR: ready for review All feedback addressed, ready for reviews and removed PR: in progress Under development and/or addressing feedback labels Jun 5, 2023

adrianwyatt requested changes Jun 5, 2023

View reviewed changes

adrianwyatt added PR: feedback to address Waiting for PR owner to address comments/questions and removed PR: ready for review All feedback addressed, ready for reviews labels Jun 5, 2023

teresaqhoang suggested changes Jun 6, 2023

View reviewed changes

TaoChenOSU added 2 commits June 7, 2023 15:43

Merge branch 'main' into feature-copilotmultiuser

a646004

Address comments part 1

d973ee7

TaoChenOSU force-pushed the feature-copilotmultiuser branch from d20b494 to d973ee7 Compare June 7, 2023 23:51

Mitigate GitHub actions errors

6d86913

TaoChenOSU dismissed amsacha’s stale review via d614ed3 June 16, 2023 19:47

TaoChenOSU requested review from amsacha, dehoward, hathind-ms and teresaqhoang June 16, 2023 19:47

teresaqhoang approved these changes Jun 16, 2023

View reviewed changes

teresaqhoang and others added 4 commits June 16, 2023 12:54

Merge branch 'main' into feature-copilotmultiuser

e578d61

Merge branch 'main' into feature-copilotmultiuser

0104772

Merge branch 'main' into feature-copilotmultiuser

1c384cd

Merge branch 'main' into feature-copilotmultiuser

9846f52

amsacha approved these changes Jun 17, 2023

View reviewed changes

Merge branch 'main' into feature-copilotmultiuser

29b7ac4

amsacha requested a review from a team as a code owner June 17, 2023 00:11

adrianwyatt approved these changes Jun 17, 2023

View reviewed changes

Merge branch 'main' into feature-copilotmultiuser

ae54347

adrianwyatt added this pull request to the merge queue Jun 17, 2023

Merged via the queue into main with commit 18a35e5 Jun 17, 2023

adrianwyatt added a commit that referenced this pull request Jun 17, 2023

Revert "Copilot Chat: Multi-user support with SignalR (#1345)" (#1534)

8357616

This reverts commit 18a35e5. We're seeing 401s after deployment.

adrianwyatt added a commit that referenced this pull request Jun 19, 2023

Revert "Revert "Copilot Chat: Multi-user support with SignalR (#1345)" (

3ccff81

#1534)" (#1556) This reverts commit 8357616 which re-merged multi-user Copilot Chat

alliscode mentioned this pull request Jun 21, 2023

CC: Store User ID instead of username / email in ChatMessage and MemorySource #1646

Closed

shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023

Revert "Copilot Chat: Multi-user support with SignalR (microsoft#1345)…

a12fb09

…" (microsoft#1534) This reverts commit 18a35e5. We're seeing 401s after deployment.

golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023

Revert "Copilot Chat: Multi-user support with SignalR (microsoft#1345)…

7332556

…" (microsoft#1534) This reverts commit e90daf2. We're seeing 401s after deployment.

teresaqhoang deleted the feature-copilotmultiuser branch December 13, 2023 23:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Copilot Chat: Multi-user support with SignalR#1345

Copilot Chat: Multi-user support with SignalR#1345
adrianwyatt merged 45 commits intomainfrom
feature-copilotmultiuser

TaoChenOSU commented Jun 5, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

teresaqhoang left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

TaoChenOSU commented Jun 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation and Context

Description

Contribution Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

teresaqhoang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

TaoChenOSU commented Jun 5, 2023 •

edited

Loading