Feature multiuserchat stage1#1049
Merged
TaoChenOSU merged 15 commits intomicrosoft:feature-multiusercopilotchatfrom May 18, 2023
Merged
Feature multiuserchat stage1#1049TaoChenOSU merged 15 commits intomicrosoft:feature-multiusercopilotchatfrom
TaoChenOSU merged 15 commits intomicrosoft:feature-multiusercopilotchatfrom
Conversation
The first step to enable a multi-user chat experience is to have a mechanism to allow users to join chat sessions. With this PR, users will be able to join chat sessions via chat ids shared by others. 1. A new model called ChatParticipant to manage users in chat sessions. 2. A new ChatParticipantController to provide a service API to join chat sessions via chat ids. 3. Remove user id in the ChatSession model since all users will be managed by ChatParticipant. 4. Front end to retrieve chat ids for sharing. 5. Front end to join chat sessions via chat ids.     Note that we still need to have a real-time message relay system to have a complete multi-user chat experience.
…ave front end respond + cleanup + yarn and package.json update # Conflicts: # samples/apps/copilot-chat-app/webapi/CopilotChat/Controllers/ChatController.cs
TaoChenOSU
added a commit
to TaoChenOSU/semantic-kernel-fork
that referenced
this pull request
May 19, 2023
Combining and bringing in stage 1 of the multi user chat experience: - join chats via chat ids - signal R broadcasting from frontend and backend - signal R middleware - limit broadcasting to chat id groups - broadcast document uploading The code builds clean without any errors or warnings The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format All unit tests pass, and I have added new tests where possible I didn't break anyone 😄 --------- Co-authored-by: Tao Chen <TaoChenOSU@users.noreply.github.com> Co-authored-by: Tao Chen <taochen@microsoft.com>
TaoChenOSU
added a commit
to TaoChenOSU/semantic-kernel-fork
that referenced
this pull request
May 19, 2023
Combining and bringing in stage 1 of the multi user chat experience: - join chats via chat ids - signal R broadcasting from frontend and backend - signal R middleware - limit broadcasting to chat id groups - broadcast document uploading The code builds clean without any errors or warnings The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format All unit tests pass, and I have added new tests where possible I didn't break anyone 😄 --------- Co-authored-by: Tao Chen <TaoChenOSU@users.noreply.github.com> Co-authored-by: Tao Chen <taochen@microsoft.com>
TaoChenOSU
added a commit
to TaoChenOSU/semantic-kernel-fork
that referenced
this pull request
May 22, 2023
Combining and bringing in stage 1 of the multi user chat experience: - join chats via chat ids - signal R broadcasting from frontend and backend - signal R middleware - limit broadcasting to chat id groups - broadcast document uploading The code builds clean without any errors or warnings The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format All unit tests pass, and I have added new tests where possible I didn't break anyone 😄 --------- Co-authored-by: Tao Chen <TaoChenOSU@users.noreply.github.com> Co-authored-by: Tao Chen <taochen@microsoft.com>
TaoChenOSU
added a commit
to TaoChenOSU/semantic-kernel-fork
that referenced
this pull request
May 22, 2023
Combining and bringing in stage 1 of the multi user chat experience: - join chats via chat ids - signal R broadcasting from frontend and backend - signal R middleware - limit broadcasting to chat id groups - broadcast document uploading The code builds clean without any errors or warnings The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format All unit tests pass, and I have added new tests where possible I didn't break anyone 😄 --------- Co-authored-by: Tao Chen <TaoChenOSU@users.noreply.github.com> Co-authored-by: Tao Chen <taochen@microsoft.com>
TaoChenOSU
added a commit
that referenced
this pull request
May 22, 2023
Combining and bringing in stage 1 of the multi user chat experience: - join chats via chat ids - signal R broadcasting from frontend and backend - signal R middleware - limit broadcasting to chat id groups - broadcast document uploading The code builds clean without any errors or warnings The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format All unit tests pass, and I have added new tests where possible I didn't break anyone 😄 --------- Co-authored-by: Tao Chen <TaoChenOSU@users.noreply.github.com> Co-authored-by: Tao Chen <taochen@microsoft.com>
amsacha
added a commit
to amsacha/semantic-kernel
that referenced
this pull request
May 23, 2023
Combining and bringing in stage 1 of the multi user chat experience: - join chats via chat ids - signal R broadcasting from frontend and backend - signal R middleware - limit broadcasting to chat id groups - broadcast document uploading The code builds clean without any errors or warnings The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format All unit tests pass, and I have added new tests where possible I didn't break anyone 😄 --------- Co-authored-by: Tao Chen <TaoChenOSU@users.noreply.github.com> Co-authored-by: Tao Chen <taochen@microsoft.com>
amsacha
added a commit
that referenced
this pull request
May 23, 2023
Combining and bringing in stage 1 of the multi user chat experience: - join chats via chat ids - signal R broadcasting from frontend and backend - signal R middleware - limit broadcasting to chat id groups - broadcast document uploading The code builds clean without any errors or warnings The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format All unit tests pass, and I have added new tests where possible I didn't break anyone 😄 --------- Co-authored-by: Tao Chen <TaoChenOSU@users.noreply.github.com> Co-authored-by: Tao Chen <taochen@microsoft.com>
amsacha
added a commit
that referenced
this pull request
May 25, 2023
Combining and bringing in stage 1 of the multi user chat experience: - join chats via chat ids - signal R broadcasting from frontend and backend - signal R middleware - limit broadcasting to chat id groups - broadcast document uploading The code builds clean without any errors or warnings The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format All unit tests pass, and I have added new tests where possible I didn't break anyone 😄 --------- Co-authored-by: Tao Chen <TaoChenOSU@users.noreply.github.com> Co-authored-by: Tao Chen <taochen@microsoft.com>
amsacha
added a commit
that referenced
this pull request
May 25, 2023
Combining and bringing in stage 1 of the multi user chat experience: - join chats via chat ids - signal R broadcasting from frontend and backend - signal R middleware - limit broadcasting to chat id groups - broadcast document uploading The code builds clean without any errors or warnings The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format All unit tests pass, and I have added new tests where possible I didn't break anyone 😄 --------- Co-authored-by: Tao Chen <TaoChenOSU@users.noreply.github.com> Co-authored-by: Tao Chen <taochen@microsoft.com>
amsacha
added a commit
that referenced
this pull request
May 31, 2023
Combining and bringing in stage 1 of the multi user chat experience: - join chats via chat ids - signal R broadcasting from frontend and backend - signal R middleware - limit broadcasting to chat id groups - broadcast document uploading The code builds clean without any errors or warnings The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format All unit tests pass, and I have added new tests where possible I didn't break anyone 😄 --------- Co-authored-by: Tao Chen <TaoChenOSU@users.noreply.github.com> Co-authored-by: Tao Chen <taochen@microsoft.com>
amsacha
added a commit
that referenced
this pull request
May 31, 2023
Combining and bringing in stage 1 of the multi user chat experience: - join chats via chat ids - signal R broadcasting from frontend and backend - signal R middleware - limit broadcasting to chat id groups - broadcast document uploading The code builds clean without any errors or warnings The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format All unit tests pass, and I have added new tests where possible I didn't break anyone 😄 --------- Co-authored-by: Tao Chen <TaoChenOSU@users.noreply.github.com> Co-authored-by: Tao Chen <taochen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Combining and bringing in stage 1 of the multi user chat experience:
Description
Contribution Checklist
The code builds clean without any errors or warnings
The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
All unit tests pass, and I have added new tests where possible
I didn't break anyone 😄