Copilot chat: join chats via chat ids#870
Merged
adrianwyatt merged 6 commits intomicrosoft:feature-copilotchatmultiuserfrom May 10, 2023
Merged
Conversation
b2f3ae5 to
108c25a
Compare
Vivihung
suggested changes
May 10, 2023
Member
Vivihung
left a comment
There was a problem hiding this comment.
Thanks for the PR. Would like to see some comments in ChatParticipantController.cs.
samples/apps/copilot-chat-app/webapi/Controllers/ChatHistoryController.cs
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapi/Controllers/ChatParticipantController.cs
Show resolved
Hide resolved
amsacha
previously approved these changes
May 10, 2023
The base branch was changed.
hathind-ms
previously approved these changes
May 10, 2023
adrianwyatt
requested changes
May 10, 2023
samples/apps/copilot-chat-app/webapi/Controllers/ChatParticipantController.cs
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapi/Controllers/ChatParticipantController.cs
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapi/Controllers/ChatParticipantController.cs
Outdated
Show resolved
Hide resolved
0fa5a2c to
d345fec
Compare
…t_chat_invitation_via_chat_id
adrianwyatt
approved these changes
May 10, 2023
TaoChenOSU
added a commit
to TaoChenOSU/semantic-kernel-fork
that referenced
this pull request
May 17, 2023
The first step to enable a multi-user chat experience is to have a mechanism to allow users to join chat sessions. With this PR, users will be able to join chat sessions via chat ids shared by others. 1. A new model called ChatParticipant to manage users in chat sessions. 2. A new ChatParticipantController to provide a service API to join chat sessions via chat ids. 3. Remove user id in the ChatSession model since all users will be managed by ChatParticipant. 4. Front end to retrieve chat ids for sharing. 5. Front end to join chat sessions via chat ids.     Note that we still need to have a real-time message relay system to have a complete multi-user chat experience.
amsacha
pushed a commit
to amsacha/semantic-kernel
that referenced
this pull request
May 17, 2023
The first step to enable a multi-user chat experience is to have a mechanism to allow users to join chat sessions. With this PR, users will be able to join chat sessions via chat ids shared by others. 1. A new model called ChatParticipant to manage users in chat sessions. 2. A new ChatParticipantController to provide a service API to join chat sessions via chat ids. 3. Remove user id in the ChatSession model since all users will be managed by ChatParticipant. 4. Front end to retrieve chat ids for sharing. 5. Front end to join chat sessions via chat ids.     Note that we still need to have a real-time message relay system to have a complete multi-user chat experience.
amsacha
pushed a commit
to amsacha/semantic-kernel
that referenced
this pull request
May 17, 2023
The first step to enable a multi-user chat experience is to have a mechanism to allow users to join chat sessions. With this PR, users will be able to join chat sessions via chat ids shared by others. 1. A new model called ChatParticipant to manage users in chat sessions. 2. A new ChatParticipantController to provide a service API to join chat sessions via chat ids. 3. Remove user id in the ChatSession model since all users will be managed by ChatParticipant. 4. Front end to retrieve chat ids for sharing. 5. Front end to join chat sessions via chat ids.     Note that we still need to have a real-time message relay system to have a complete multi-user chat experience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The first step to enable a multi-user chat experience is to have a mechanism to allow users to join chat sessions.
With this PR, users will be able to join chat sessions via chat ids shared by others.
Description
Note that we still need to have a real-time message relay system to have a complete multi-user chat experience.
Contribution Checklist
dotnet format