.Net MEVD: Unify collection deletion and creation#10958
Merged
adamsitnik merged 12 commits intomicrosoft:mainfrom Mar 18, 2025
Merged
.Net MEVD: Unify collection deletion and creation#10958adamsitnik merged 12 commits intomicrosoft:mainfrom
adamsitnik merged 12 commits intomicrosoft:mainfrom
Conversation
- introduce CollectionConformanceTests - make GenerateNextKey thread-safe - make sure the tests don't create collection if there is no need to - implement the tests for Postgres, SQL Server and Redis (partially)
…go, InMemory, Sqlite, Cosmos and Azure AI Search
…tionAndCreation # Conflicts: # dotnet/src/VectorDataIntegrationTests/RedisIntegrationTests/Support/RedisGenericDataModelFixture.cs # dotnet/src/VectorDataIntegrationTests/RedisIntegrationTests/Support/RedisSimpleModelFixture.cs # dotnet/src/VectorDataIntegrationTests/VectorDataIntegrationTests/Collections/CollectionConformanceTests.cs
8d1b590 to
89673b5
Compare
westey-m
reviewed
Mar 13, 2025
...rDataIntegrationTests/QdrantIntegrationTests/Collections/QdrantCollectionConformanceTests.cs
Outdated
Show resolved
Hide resolved
westey-m
approved these changes
Mar 13, 2025
…named vector for Qdrant
westey-m
approved these changes
Mar 14, 2025
roji
approved these changes
Mar 15, 2025
Member
roji
left a comment
There was a problem hiding this comment.
Thanks @adamsitnik! See minor comments below.
...rs/Connectors.Memory.AzureCosmosDBMongoDB/AzureCosmosDBMongoDBVectorStoreRecordCollection.cs
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.InMemory/InMemoryVectorStoreRecordCollection.cs
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Weaviate/WeaviateVectorStoreRecordCollection.cs
Show resolved
Hide resolved
dotnet/src/VectorDataIntegrationTests/SqliteIntegrationTests/Support/SqliteFixture.cs
Show resolved
Hide resolved
Member
|
Thoughts about merging this to the feature branch vs. main? This does change behavior so maybe better to wait with it... |
…percase ASCII letter
adamsitnik
commented
Mar 18, 2025
dotnet/src/IntegrationTests/Connectors/Memory/Weaviate/WeaviateVectorStoreTests.cs
Outdated
Show resolved
Hide resolved
…eVectorStoreTests.cs
westey-m
approved these changes
Mar 18, 2025
roji
approved these changes
Mar 18, 2025
This was referenced Mar 18, 2025
jcruzmot-te
pushed a commit
to thousandeyes/aia-semantic-kernel
that referenced
this pull request
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #10882