Delete redundant service verb#406
Conversation
derrickstolee
left a comment
There was a problem hiding this comment.
A quick git grep service found an interesting case hat might cause some problems:
Scalar.Installer.Windows/Setup.iss: Exec('scalar.exe', 'service --help', '', SW_HIDE, ewWaitUntilTerminated, ResultCode);
Likely this is a simple replacement, like s/service --help/list --help/.
The "TODO" above this is interesting: procedure StopMaintenanceTasks();
var
ResultCode: integer;
begin
// TODO: #185 Instead of calling --help, use the correct action for stopping the
// maintenance task
Exec('scalar.exe', 'service --help', '', SW_HIDE, ewWaitUntilTerminated, ResultCode);
end;That issue (#185) was closed by @derrickstolee saying:
..but looking at #236, it appears this was closed without a code change. You said:
Do we still need to implement this TODO and stop maintenance tasks? Don't we really just need a new verb I can replace this with a dummy command again for now, but feels like perhaps #185 should be reopened, no? |
I agree with your investigation and conclusion. Thanks! |
Delete the ServiceVerb which is now redundant; the ListVerb performs the exact same actions. Also delete unit tests for this verb.
Reopened the issue: #185 (comment) |
c075657 to
bb1ae4a
Compare
Delete the
ServiceVerbwhich is now redundant; theListVerbperforms the exact same actions.