Remove .scalar folder#251
Merged
derrickstolee merged 13 commits intomicrosoft:masterfrom Nov 26, 2019
derrickstolee:scalar-folder-round-2
Merged
Remove .scalar folder#251derrickstolee merged 13 commits intomicrosoft:masterfrom derrickstolee:scalar-folder-round-2
derrickstolee merged 13 commits intomicrosoft:masterfrom
derrickstolee:scalar-folder-round-2
Conversation
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Contributor
Author
|
/azp run microsoft.scalar |
|
Azure Pipelines successfully started running 1 pipeline(s). |
The previous algorithm that looked for an enlistment without a .scalar directory did not make a distinction between "src/.git" and just ".git" as to where the working directory was. Since the ScalarEnlistment class automatically added a "src" dir to the enlistment root, that caused maintenance verbs to fail when run inside the "src" folder (it would add a second "src" dir). Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
jrbriggs
reviewed
Nov 26, 2019
jrbriggs
reviewed
Nov 26, 2019
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Contributor
Author
|
/azp run microsoft.scalar |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chrisd8088
added a commit
to chrisd8088/scalar
that referenced
this pull request
Oct 7, 2020
The corresponding method in the MacPlatform.Shared.cs file was removed in commit 2a75485 in PR microsoft#251, so we can also drop GetNamedPipeNameImplementation() from the POSIX platform as well.
chrisd8088
added a commit
to chrisd8088/scalar
that referenced
this pull request
Oct 9, 2020
The corresponding method in the MacPlatform.Shared.cs file was removed in commit 2a75485 in PR microsoft#251, so we can also drop GetNamedPipeNameImplementation() from the POSIX platform as well.
chrisd8088
added a commit
to chrisd8088/scalar
that referenced
this pull request
Oct 9, 2020
The corresponding method in the MacPlatform.Shared.cs file was removed in commit 2a75485 in PR microsoft#251, so we can also drop GetNamedPipeNameImplementation() from the POSIX platform as well.
chrisd8088
added a commit
to chrisd8088/scalar
that referenced
this pull request
Oct 10, 2020
The corresponding method in the MacPlatform.Shared.cs file was removed in commit 2a75485 in PR microsoft#251, so we can also drop GetNamedPipeNameImplementation() from the POSIX platform as well.
chrisd8088
added a commit
to chrisd8088/scalar
that referenced
this pull request
Oct 10, 2020
The corresponding method in the MacPlatform.Shared.cs file was removed in commit 2a75485 in PR microsoft#251, so we can also drop GetNamedPipeNameImplementation() from the POSIX platform as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #239 which was reverted in #248.
The only change is the algorithm for finding the enlistment root. The previous algorithm had an issue when called from the
srcfolder as it would create the enlistment root there and then theScalarEnlistmentclass still automatically addedsrcto that for the working directory root.This was not caught by the functional tests because they run the maintenance verbs from the enlistment root, not the
srcfolder. I didn't catch it in testing because my local testing was from the old mechanism usinggit configinstead. The performance test suite does reveal this problem.As a follow-up, we should remove the "working directory backing root" (#250).