Revert "Merge pull request #239"#248
Merged
derrickstolee merged 1 commit intomicrosoft:masterfrom Nov 22, 2019
derrickstolee:log-location
Merged
Revert "Merge pull request #239"#248derrickstolee merged 1 commit intomicrosoft:masterfrom derrickstolee:log-location
derrickstolee merged 1 commit intomicrosoft:masterfrom
derrickstolee:log-location
Conversation
Contributor
Author
|
@kewillford if you are still around when builds are green, please merge this. I'll be offline the rest of the night. |
kewillford
approved these changes
Nov 21, 2019
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Merged
derrickstolee
added a commit
that referenced
this pull request
Nov 26, 2019
This replaces #239 which was reverted in #248. The only change is the algorithm for finding the enlistment root. The previous algorithm had an issue when called from the `src` folder as it would create the enlistment root there and then the `ScalarEnlistment` class still automatically added `src` to that for the working directory root. This was not caught by the functional tests because they run the maintenance verbs from the enlistment root, not the `src` folder. I didn't catch it in testing because my local testing was from the old mechanism using `git config` instead. The performance test suite does reveal this problem. As a follow-up, we should remove the "working directory backing root" (#250).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kewillford noticed that the perf builds started failing after #239 merged. Revert it for now, and I'll investigate tomorrow.