Conversation
|
|
don't forget that you might need to merge these changes in .63 and .62 branches |
|
should there be a test case in the tester app? |
|
Maybe mark with the TODO markers since it is a difference from upstream currently? And @harrieshin I think adding a test case will cause more react-native core/macOS divergence |
Actually we already have a test case for looping animation in the Native Animated Example page, the bug didn't surface there probably because the shimmer animation uses a hook instead. |
should we extend the test case so that it has an example that uses the hook then? |
I think that'd be helpful, but the scope might be bigger than I thought so let's do a followup on it. |
* Fix animation bug (#763) * pod install * fix pod errors * fix pod errors * fix pod errors
Please select one of the following
Summary
I'm working on a FURN control microsoft/fluentui-react-native#669 that uses the animated library, and there's a bug where animation doesn't loop when the native driver is enabled. There's already a fix facebook#29585 for the bug but it hasn't been merged to upstream. I want to bring in this fix into our fork to unblock my work.
Changelog
[Apple] [Bug] - bug fix for Animated
Test Plan
Tested the animation logic in RNTester, I was able to repro the bug and verified that the change fixes the bug.