Fix natively driven animations not getting reset properly#29585
Closed
phamfoo wants to merge 1 commit intofacebook:masterfrom
Closed
Fix natively driven animations not getting reset properly#29585phamfoo wants to merge 1 commit intofacebook:masterfrom
phamfoo wants to merge 1 commit intofacebook:masterfrom
Conversation
Base commit: fe79abb |
Base commit: fe79abb |
44182e0 to
979cef4
Compare
4 tasks
Contributor
|
Looks good. Thanks for the contribution, @tienphaw. |
Contributor
|
@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
@yungsters merged this pull request in 129180c. |
Contributor
Author
|
Glad to see the PR finally getting merged, thanks @yungsters. BTW, is there anything I can do in my future PRs to get them reviewed faster? |
Contributor
|
I apologize on behalf of the team for the delays. We are currently trying out some new internal tooling to help review PRs more promptly. For this specific PR, one thing that would have helped is creating an RNTester example demonstrating the fix. (I already have a pending internal PR to create an example for this specific one.) |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 13, 2021
Summary: Creates a new `Animated.loop` example in RNTester that uses the native driver. This example shows the precise problem fixed by #29585 (D28383538 (129180c)). Changelog: [Internal] Reviewed By: kacieb Differential Revision: D28406914 fbshipit-source-id: 63ea7799d4b8bef8b0c1caaa3daf514ca04b7ab1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #28517
Animated.loop needs to reset the animation after each iteration but currently, natively driven animations are not getting reset properly.
Changelog
[General] [Fixed] - Fix natively driven animations not getting reset properly
Test Plan
Tested within RNTester