Skip to content

test: mark test added in PR#41224 as slow#41309

Merged
yury-s merged 1 commit into
microsoft:mainfrom
dcrousso:mark-41224-test-slow
Jun 15, 2026
Merged

test: mark test added in PR#41224 as slow#41309
yury-s merged 1 commit into
microsoft:mainfrom
dcrousso:mark-41224-test-slow

Conversation

@dcrousso

@dcrousso dcrousso commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

BrowserType.prototype.launchPersistentContext often takes ~25s to complete, so having it twice in the same test will exceed the default 30s timeout

match other tests that invoke it more than once by marking this test as slow

@dcrousso
test: mark test added in PR#41224 as slow
ce6c1b2 
`BrowserType.prototype.launchPersistentContext` often takes ~25s to complete, so having it twice in the same test will exceed the default 30s timeout

match other tests that invoke it more than once by marking this test as slow
@dcrousso dcrousso requested review from dgozman and yury-s June 15, 2026 16:46
@dcrousso dcrousso changed the title test: mark test added in PR#41224 as slow test: mark test added in #41224 as slow Jun 15, 2026
@dcrousso dcrousso changed the title test: mark test added in #41224 as slow test: mark test added in PR#41224 as slow Jun 15, 2026
@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

7341 passed, 1122 skipped

Merge workflow run.

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

2 flaky ⚠️ [chromium-library] › library/tracing.spec.ts:430 › should produce screencast frames crop `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-page] › page/workers.spec.ts:190 › should attribute network activity for worker inside iframe to the iframe `@chromium-ubuntu-22.04-node22`

39565 passed, 743 skipped

Merge workflow run.

@yury-s yury-s merged commit c2ac911 into microsoft:main Jun 15, 2026
46 checks passed
@dcrousso dcrousso deleted the mark-41224-test-slow branch June 15, 2026 17:52
@dcrousso dcrousso mentioned this pull request Jun 17, 2026
Merged
dcrousso added a commit that referenced this pull request Jun 17, 2026
@dcrousso
Revert "fix(firefox): treat navigationCommitted events without `nav…
e5cd8b3 
…igationId` as same-document URL updates (#41224)" (#41349)

this is a partial revert for commits 81881e2 <#41224> and c2ac911 <#41309>

leep the test added as that's still a valuable scenario to check, though it's skipped for Firefox due to the known issue

fixes <#41347>
yury-s pushed a commit that referenced this pull request Jun 18, 2026
@dcrousso
cherry-pick(#41309, #43149): Revert "fix(firefox): treat `navigationC…
b8a0fc3 
…ommitted` events without `navigationId` as same-document URL updates (#41224)" (#41350)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yury-s yury-s yury-s approved these changes
@dgozman dgozman Awaiting requested review from dgozman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dcrousso @yury-s