Revert "fix(firefox): treat navigationCommitted events without navigationId as same-document URL updates (#41224)"#41349
Merged
Conversation
dgozman
approved these changes
Jun 17, 2026
| annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/41216' }, | ||
| }, async ({ browserType, createUserDataDir }) => { | ||
| }, async ({ browserType, createUserDataDir, browserName }) => { | ||
| it.skip(browserName === 'firefox'); |
Collaborator
There was a problem hiding this comment.
Suggested change
| it.skip(browserName === 'firefox'); | |
| it.fixme(browserName === 'firefox'); |
…igationId` as same-document URL updates (microsoft#41224)" This is a partial revert for commits 81881e2 and c2ac911. Keep the test added as that's still a valuable scenario to check, though it's skipped for Firefox due to the known issue.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
yury-s
approved these changes
Jun 17, 2026
Contributor
Test results for "tests 1"6 flaky39596 passed, 744 skipped Merge workflow run. |
Contributor
Test results for "MCP"7354 passed, 1122 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a partial revert for commits 81881e2 #41224 and c2ac911 #41309
leep the test added as that's still a valuable scenario to check, though it's skipped for Firefox due to the known issue
fixes #41347