fix(codegen): do not reset current tool upon clearing highlight#33822
Merged
dgozman merged 1 commit intomicrosoft:mainfrom Dec 3, 2024
Merged
fix(codegen): do not reset current tool upon clearing highlight#33822dgozman merged 1 commit intomicrosoft:mainfrom
dgozman merged 1 commit intomicrosoft:mainfrom
Conversation
This breaks when VSCode updates the highlight during recording. The problem was exposed by microsoft#33632.
Contributor
Test results for "tests 1"3 flaky37188 passed, 650 skipped Merge workflow run. |
pavelfeldman
approved these changes
Dec 2, 2024
dgozman
added a commit
that referenced
this pull request
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This breaks when VSCode updates the highlight during recording. The problem was exposed by #33632.
I wasn't able to write a test as a part of
codegen.spec,debug-controller.specor in theplaywright-vscoderepository. It seems like timing is very important to reproduce the issue.Fixes #33787.