chore: highlight edited locator while recording#33632
Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom Nov 15, 2024
Merged
chore: highlight edited locator while recording#33632pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman merged 1 commit intomicrosoft:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
Nov 15, 2024
| highlight = { elements }; | ||
| else | ||
| this._actionSelectorModel = null; | ||
| highlight = 'clear'; |
Contributor
There was a problem hiding this comment.
Doesn't this always clear highlight when recorder switches from state.ariaTemplate to state.actionSelector? I think this should be:
else if (highlight === 'noop')
highlight = 'clear';
Member
Author
There was a problem hiding this comment.
This code only runs if the template was the thing that changed last, so should be ok?
| if (!state.actionSelector && !state.ariaTemplate) | ||
| this._actionSelectorModel = null; | ||
|
|
||
| if (this.state.mode === 'none' || this.state.mode === 'standby') |
Contributor
There was a problem hiding this comment.
This mode check is gone. Do we clear highlight upon performing an action on the recorder side?
Member
Author
There was a problem hiding this comment.
I think we do, so should be unrelated to that scenario.
6bfbb19 to
0580258
Compare
0580258 to
cc24cf9
Compare
Contributor
Test results for "tests 1"1 flaky36912 passed, 650 skipped Merge workflow run. |
pavelfeldman
added a commit
that referenced
this pull request
Nov 15, 2024
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Nov 29, 2024
This breaks when VSCode updates the highlight during recording. The problem was exposed by microsoft#33632.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.