Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5496 +/- ##
==========================================
+ Coverage 84.03% 85.32% +1.28%
==========================================
Files 59 59
Lines 18621 18621
==========================================
+ Hits 15649 15889 +240
+ Misses 2972 2732 -240 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6847d7e to
f5a3d4c
Compare
Collaborator
Author
|
Will need to cherry-pick to release/2.5 and release/2.4 |
ProjectsByJackHe
approved these changes
Oct 7, 2025
guhetier
added a commit
that referenced
this pull request
Oct 9, 2025
guhetier
added a commit
that referenced
this pull request
Oct 9, 2025
This was referenced Oct 9, 2025
guhetier
added a commit
that referenced
this pull request
Oct 10, 2025
guhetier
added a commit
that referenced
this pull request
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5495 by adding the linker flag /CETCOMPAT, to advertise CET Shadow stacks supports.
Testing
CI
Documentation
N/A