Add CET Shadow stack compatibility (#5496)#5508
Merged
guhetier merged 1 commit intorelease/2.4from Oct 10, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/2.4 #5508 +/- ##
===============================================
- Coverage 86.55% 85.93% -0.62%
===============================================
Files 56 56
Lines 17338 17338
===============================================
- Hits 15007 14900 -107
- Misses 2331 2438 +107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anrossi
reviewed
Oct 10, 2025
| ${SYSTEM_PROCESSOR} STREQUAL "x86" OR | ||
| ${SYSTEM_PROCESSOR} STREQUAL "win32") | ||
|
|
||
| string(APPEND MSQUIC_LINK_FLAGS " /CETCOMPAT") |
Collaborator
There was a problem hiding this comment.
I should have caught this on the original PR, but why is this doing string appending? I think CMAKE supports make the link flags a list of items and then seamlessly making it a string when setting the link flags.
Collaborator
Author
There was a problem hiding this comment.
It follows the pattern introduced in #5454 (you see it in this diff because of a merge conflict).
anrossi
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5495 by adding the linker flag /CETCOMPAT, to advertise CET Shadow stacks supports.
Cherry-pick of #5496.
Testing
CI
Documentation
N/A