CP: Do not send CONNECTION_CLOSE frames in draining state.#5492
Merged
guhetier merged 1 commit intorelease/2.5from Oct 7, 2025
Merged
CP: Do not send CONNECTION_CLOSE frames in draining state.#5492guhetier merged 1 commit intorelease/2.5from
guhetier merged 1 commit intorelease/2.5from
Conversation
Collaborator
Author
|
MIght need to CP #5453 too. |
csujedihy
approved these changes
Oct 6, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/2.5 #5492 +/- ##
===============================================
- Coverage 87.38% 86.97% -0.42%
===============================================
Files 59 59
Lines 18173 18174 +1
===============================================
- Hits 15880 15806 -74
- Misses 2293 2368 +75 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… draining state (#5477)
44d70fd to
103b62a
Compare
csujedihy
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick #5477
Some spurious test failures show a pattern when the two peers entered a loop of sending CONNECTION_CLOSE frames to each other. This regression was introduced by #5107.
According to RFC 9000:
(The RFC is not explicit about what happens when a peer in the "closing" state receives a CONNECTION_CLOSE, but since it means both peers are closing the connection, it can stop sending additional CONNECTION_CLOSE).
However, #5107 was re-sending CONNECTION_CLOSE frame both in "closing" and "draining" state. This PR fixes it.
Testing
CI. The issue is timing dependent and can't be reliably reproduced.
Documentation
N/A