Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5453 +/- ##
==========================================
+ Coverage 84.61% 84.68% +0.07%
==========================================
Files 59 59
Lines 18600 18600
==========================================
+ Hits 15738 15752 +14
+ Misses 2862 2848 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
csujedihy
approved these changes
Sep 16, 2025
Collaborator
|
@fernandoareias thanks a lot for fixing the mac osx build. Do you mind completing the CLA agreement so we can get this merged? |
Contributor
Author
|
@microsoft-github-policy-service agree |
guhetier
pushed a commit
that referenced
this pull request
Oct 6, 2025
guhetier
pushed a commit
that referenced
this pull request
Oct 9, 2025
Merged
guhetier
added a commit
that referenced
this pull request
Oct 10, 2025
* fix: update OpenSSL submodule configuration for macOS SDK detection (#5453) * Remove the L from unevaluated string literals. (#4609) This resolves build failures on macOS 15 "Sequoia" / XCode Command Line Tools 16 detected while attempting to update vcpkg's build and test lab: microsoft/vcpkg#41307 Example: ``` /Users/vcpkg/Data/b/msquic/src/v2.4.5-9d07a67b94.clean/src/core/quicdef.h:243:66: error: encoding prefix 'L' on an unevaluated string literal has no effect [-Werror,-Winvalid-unevaluated-string] 243 | CXPLAT_STATIC_ASSERT(IS_POWER_OF_TWO(QUIC_MAX_RANGE_ALLOC_SIZE), L"Must be power of two"); | ^ ``` --------- Co-authored-by: Fernando Areias <nando.calheirosx@gmail.com> Co-authored-by: Billy O'Neal <bion@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #5446
Testing
CI
Documentation
N/A