Skip to content

[CP] Fix MacOs build#5509

Merged
guhetier merged 2 commits intorelease/2.4from
guhetier/macos_build_cp_2.4
Oct 10, 2025
Merged

[CP] Fix MacOs build#5509
guhetier merged 2 commits intorelease/2.4from
guhetier/macos_build_cp_2.4

Conversation

@guhetier
Copy link
Collaborator

@guhetier guhetier commented Oct 9, 2025

Description

Fix #5446
Cherry-pick of #5453 and #4609

Testing

CI

Documentation

N/A

@guhetier guhetier requested a review from a team as a code owner October 9, 2025 18:28
This resolves build failures on macOS 15 "Sequoia" / XCode Command Line Tools 16 detected while attempting to update vcpkg's build and test lab: microsoft/vcpkg#41307

Example:

```
/Users/vcpkg/Data/b/msquic/src/v2.4.5-9d07a67b94.clean/src/core/quicdef.h:243:66: error: encoding prefix 'L' on an unevaluated string literal has no effect [-Werror,-Winvalid-unevaluated-string]
  243 | CXPLAT_STATIC_ASSERT(IS_POWER_OF_TWO(QUIC_MAX_RANGE_ALLOC_SIZE), L"Must be power of two");
      |                                                                  ^
```
@guhetier guhetier changed the title [CP] Update OpenSSL submodule configuration for macOS SDK detection [CP] Fix MacOs build Oct 9, 2025
@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.59%. Comparing base (1d9464a) to head (8d076f1).
⚠️ Report is 1 commits behind head on release/2.4.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/2.4    #5509      +/-   ##
===============================================
+ Coverage        86.55%   86.59%   +0.04%     
===============================================
  Files               56       56              
  Lines            17338    17338              
===============================================
+ Hits             15007    15014       +7     
+ Misses            2331     2324       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@guhetier guhetier merged commit b89778f into release/2.4 Oct 10, 2025
377 of 378 checks passed
@guhetier guhetier deleted the guhetier/macos_build_cp_2.4 branch October 10, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants