Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5107 +/- ##
==========================================
- Coverage 87.20% 86.81% -0.40%
==========================================
Files 59 59
Lines 18027 18037 +10
==========================================
- Hits 15720 15658 -62
- Misses 2307 2379 +72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
guhetier
reviewed
May 22, 2025
guhetier
previously approved these changes
Jun 2, 2025
mtfriesen
reviewed
Jun 3, 2025
mtfriesen
previously approved these changes
Jun 3, 2025
guhetier
reviewed
Jun 3, 2025
sm-msft
reviewed
Jun 3, 2025
guhetier
reviewed
Jun 3, 2025
|
|
||
| // | ||
| // Private flag of the QUIC_CONNECTION_SHUTDOWN_FLAGS enum used for indicating | ||
| // the type of error code being passed in. Not exposed to apps because they |
Collaborator
There was a problem hiding this comment.
nti:
Suggested change
| // the type of error code being passed in. Not exposed to apps because they | |
| // a QUIC_STATUS is being passed (and not a QUIC_ERROR). | |
| // Not exposed to apps because they |
Collaborator
Author
There was a problem hiding this comment.
The "not a QUIC_ERROR" isn't actually correct either 😄 I think I'd rather just leave it as is for now and not write a massive comment explaining the various types of errors in MsQuic
guhetier
approved these changes
Jun 3, 2025
Collaborator
guhetier
left a comment
There was a problem hiding this comment.
Slight nitpick to make the comment for precise and readily useful, good to go otherwise.
nibanks
added a commit
that referenced
this pull request
Jun 4, 2025
nibanks
added a commit
that referenced
this pull request
Jun 19, 2025
This was referenced Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resend the connection close if more data is received after shutdown. Fixes #4933.
Testing
CI/CD
Documentation
N/A