modified cmake to disable xdp for arm architecture#5343
Merged
gaurav2699 merged 1 commit intomainfrom Aug 11, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5343 +/- ##
==========================================
- Coverage 86.68% 85.44% -1.24%
==========================================
Files 59 59
Lines 18308 18308
==========================================
- Hits 15870 15644 -226
- Misses 2438 2664 +226 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mtfriesen
approved these changes
Aug 11, 2025
guhetier
pushed a commit
that referenced
this pull request
Aug 14, 2025
guhetier
added a commit
that referenced
this pull request
Aug 15, 2025
anrossi
pushed a commit
that referenced
this pull request
Sep 12, 2025
anrossi
added a commit
that referenced
this pull request
Sep 12, 2025
… (#5442) Co-authored-by: Gaurav Singh <gaurasingh@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the purpose of and changes within this Pull Request.
The undock pipeline uses the same cmake flags for all the archs of a target container which means it will throw an error when QUIC_LINUX_XDP_ENABLED is on for arm architectures as its not supported. This PR adds a check to disable the flag for arm archs.
Testing
Do any existing tests cover this change? Are new tests needed?
Documentation
Is there any documentation impact for this change?