CP: Modified cmake to disable xdp for arm architecture #5357
CP: Modified cmake to disable xdp for arm architecture #5357guhetier merged 1 commit intorelease/2.5from
Conversation
| if(CMAKE_SYSTEM_PROCESSOR MATCHES "^(arm|aarch64)$") | ||
| set(QUIC_LINUX_XDP_ENABLED OFF CACHE BOOL "XDP not supported on ARM architectures" FORCE) | ||
| else() | ||
| option(QUIC_LINUX_XDP_ENABLED "Enables XDP support" OFF) |
There was a problem hiding this comment.
I know this is a cherry-pick, but this works? It looks like it just turns off Linux XDP always
There was a problem hiding this comment.
As discussed offline: it seems like when setting the option, the user provided value is used. I am not sure why the option needs to be duplicated from the top of the file, but I'll keep what works in main for here.
There was a problem hiding this comment.
@gaurav2699 If you can chime in about this it would be helpful, so we make sure the state in main is clean.
anrossi
left a comment
There was a problem hiding this comment.
I'll approve since it's a cherry-pick, but I'm curious to have my question answered
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/2.5 #5357 +/- ##
============================================
Coverage 86.11% 86.11%
============================================
Files 59 59
Lines 18173 18173
============================================
Hits 15650 15650
Misses 2523 2523 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
The undock pipeline uses the same cmake flags for all the archs of a target container which means it will throw an error when QUIC_LINUX_XDP_ENABLED is on for arm architectures as its not supported. This PR adds a check to disable the flag for arm archs.
Testing
CI
Documentation
N/A