Compatibility Bug Fixes For Latest Infer Update#39
Merged
matjin merged 7 commits intoxinshi/consolidatebackendfrom Mar 1, 2021
Merged
Compatibility Bug Fixes For Latest Infer Update#39matjin merged 7 commits intoxinshi/consolidatebackendfrom
matjin merged 7 commits intoxinshi/consolidatebackendfrom
Conversation
xi-liu-ds
reviewed
Feb 23, 2021
xinshiMSFT
approved these changes
Mar 1, 2021
xinshiMSFT
added a commit
that referenced
this pull request
Mar 3, 2021
* Update dockerfile * Remove result parser * Remove our version of Infer * Update instructions * Remove result parser from dockerfile * Updated C# model loading to use sqlite DB (#41) * Compatibility Bug Fixes For Latest Infer Update (#39) * bug fixes * edits * minor fix * run code cleanup * revert dockerfile and infer backend modifications * undo reference param updates * resource leak eport compaible with latest infer (#42) * Update C# model build * Update run steps * Update readme * Update Azure Pipelines * Remove a build script Co-authored-by: Anant Kharkar <71357868+ankharka@users.noreply.github.com> Co-authored-by: Matthew Jin <38902361+matjin@users.noreply.github.com> Co-authored-by: Xiaoyu Liu <lixiaoyu@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In updating to the latest version of Infer, we were receiving an error Abduction_case_not_implemented as a result of a mistranslation of op_Inequality, an auto-generated method in the C# Record. The bytecode for op_Inequality ended simply with ceq->ret, which caused a return of a binop expression in the translation, which is invalid in SIL. To resolve this, we inline a store and subsequent load of the binop expression, which is in turn returned.