Merged
Conversation
* bug fixes * edits * minor fix * run code cleanup * revert dockerfile and infer backend modifications * undo reference param updates
xi-liu-ds
reviewed
Mar 1, 2021
| sudo dotnet /app/AnalysisResultParser/AnalysisResultParser.dll infer-out/bugs.txt infer-out/filtered_bugs.txt $reportonfiles | ||
| mkdir -p $2 | ||
| sudo cp infer-out/filtered_bugs.txt $2 | ||
| echo "Bug report is ready at $2/" |
Member
There was a problem hiding this comment.
Should at least keep this message as echo "Bug report is ready at $1/" if we don't have a <output_path> input.
Member
Author
There was a problem hiding this comment.
Infer actually spits out relevant info like this:
Found 10 issues (console output truncated to 5, see '/app/infer-out/report.txt' for the full list)
Member
|
Overall it looks great! Just a few things:
Thanks! |
matjin
approved these changes
Mar 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Infer# will use the up-to-date Infer backend instead of our forked version going forward.